public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	John Hollowell <jhollowe@johnhollowell.com>
Subject: [pve-devel] applied-series: [PATCH v2 http-server 0/2] fix #4344: ignore unused multipart headers
Date: Mon, 6 Mar 2023 14:16:01 +0100	[thread overview]
Message-ID: <6f413c3e-e56b-79be-16dd-f9989521e6a6@proxmox.com> (raw)
In-Reply-To: <20221118013911.2655-1-jhollowe@johnhollowell.com>

Am 18/11/2022 um 02:39 schrieb John Hollowell:
> This fixes an issue where an upload request without a Content-Type in
> the file's multipart part would prevent the upload and throw
> missleading errors. This patch removes the requirement and ignores
> all multipart headers once the needed information has been extracted.
> 
> I have tested these changes against a 7.2-11 server and both a previously
> broken upload method (without the Content-Type) and using the webUI in
> Chrome (which includes a Content-Type) correctly uploads the file.
> 
> Changes since v1:
> * remove `xx` and escaping of spaces from regex
> 
> John Hollowell (2):
>   fix #4344: http-server: ignore unused multipart headers
>   Remove whitespace ignore from regex
> 
>  src/PVE/APIServer/AnyEvent.pm | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> --
> 2.30.2
> 

this went a bit under our radar, applied series now with some small merge conflict
resolved, thanks!




      parent reply	other threads:[~2023-03-06 13:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-18  1:39 [pve-devel] " John Hollowell
2022-11-18  1:39 ` [pve-devel] [PATCH v2 http-server 1/2] fix #4344: http-server: " John Hollowell
2022-11-18  1:39 ` [pve-devel] [PATCH v2 http-server 2/2] Remove whitespace ignore from regex John Hollowell
2022-11-18  9:47 ` [pve-devel] [PATCH v2 http-server 0/2] fix #4344: ignore unused multipart headers Matthias Heiserer
2023-03-06 13:16 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6f413c3e-e56b-79be-16dd-f9989521e6a6@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=jhollowe@johnhollowell.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal