Re: [pve-devel] [PATCH storage/qemu-server/manager v6] implement ova/ovf import for file based storages

[Dominik Csapak <d.csapak@proxmox.com>]

On 11/18/24 14:06, Lukas Wagner wrote:
> On Fri Nov 15, 2024 at 4:17 PM CET, Dominik Csapak wrote:
>> This series enables importing ova/ovf from directory based storages,
>> inclusive upload/download via the webui (ova only).
>>
>> It also improves the ovf importer by parsing the ostype, nics, bootorder
>> (and firmware from vmware exported files).
>>
>> I opted to move the OVF.pm to pve-storage, since there is no
>> real other place where we could put it. I put it in a new module
>> 'GuestImport'
>>
>> We now extract the images into either a given target storage or in the
>> import storage in the 'images' dir so accidentally left over images
>> are discoverable by the ui/cli.
>>
>> This version is half rebased on fabians hardening series:
>> https://lore.proxmox.com/pve-devel/20241104104221.228730-1-f.gruenbichler@proxmox.com/
>>
>> I sent the qemu-server patch from fabian again but omitted some
>> problematic checks. I add them later with a check
>> against the import vtype again (last patch in qemu-server)
> 
> Hi,
> gave this series a quick test on the respective latest master branches.
> 
> Looking good so far, but a couple of things that I've noticed were:
>   -  In the UI, checking 'Live Import' does not seem to have any effect
>      (is live import even available for OVA import?)

yes this works here, under what condition does it not for you?

>      Also, the 'Start a previously stopped VM on Proxmox VE' text does
>      not make much sense in the context of OVAs, FWICT.

true, i'll change the text for ova import

>   - A help button for the dialog would be useful
>   - Some documentation should be added before this feature is released

yes, also true. I'll prepare something

Thanks!

> 
> Tested-by: Lukas Wagner <l.wagner@proxmox.com>



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel