From: Dominik Csapak <d.csapak@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager v2 1/1] ui: implement 'Tag View' for the resource tree
Date: Mon, 26 Feb 2024 08:25:14 +0100 [thread overview]
Message-ID: <6efcd536-e9f9-47c0-9c3f-e365f3e176f7@proxmox.com> (raw)
In-Reply-To: <ff77d55d-d177-4a61-b794-9d3c900826d8@proxmox.com>
On 2/16/24 15:42, Fiona Ebner wrote:
> No real issues found during testing, but there is one thing that bugs
> me: if I have selected a guest either:
> - without tags and add a tag
> or
> - within the current tag group and remove that tag
> then the selections for the guest is lost. Since it's the selection in
> the resource view, this also affects the main area as a consequence and
> feels a bit disruptive.
>
do you mean that you have e.g. 100 selected in the 'foo' tag group
and then removed 'foo' -> select of the datacenter level?
if yes, this is not easily solvable without special handle certain
circumstances...
e.g. consider this:
vm 100 has 3 tags: foo,bar,baz
you have selected it in the 'foo' group and remove the 'foo' tag
which should now be selected? the entry in the 'bar' or 'baz' group?
the two scenarios that i could imagine would be nice is from
none -> 1 tag and reverse
but sadly the tag adding code and the selection logic
are rather separated, but i can think about how we could solve that
thanks!
prev parent reply other threads:[~2024-02-26 7:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 12:47 [pve-devel] [PATCH docs/wt/manager v2] implement tagview Dominik Csapak
2023-11-21 12:47 ` [pve-devel] [PATCH docs v2 1/1] gui: add anchor for tags chapter Dominik Csapak
2023-11-21 12:47 ` [pve-devel] [PATCH widget-toolkit v2 1/1] css: add some conditions to the tag classes for the tag view Dominik Csapak
2023-11-21 12:47 ` [pve-devel] [PATCH manager v2 1/1] ui: implement 'Tag View' for the resource tree Dominik Csapak
2024-02-16 14:42 ` Fiona Ebner
2024-02-26 7:25 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6efcd536-e9f9-47c0-9c3f-e365f3e176f7@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox