public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Fabian Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH v4 manager 1/3] api: vzdump: add call to get currently configured vzdump defaults
Date: Mon, 3 May 2021 15:02:26 +0200	[thread overview]
Message-ID: <6ee23298-7166-878c-20d9-8a21bd48da79@proxmox.com> (raw)
In-Reply-To: <20210406104152.11014-1-f.ebner@proxmox.com>

On 06.04.21 12:41, Fabian Ebner wrote:
> on a given node (and storage).
> 
> There is no datacenter/storage fallback for the bandwidth limit, so the default
> can just be returned as is. While the bandwidth limit is a root-only option when
> executing the backup, it still makes sense to return it for all users, so they
> can see what's going to be used.
> 
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> 
> Changes from v3:
>     * incorporated Thomas's feedback:
>         * style fixes
>         * return bwlimit for all users
> 
>  PVE/API2/VZDump.pm | 87 ++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 87 insertions(+)
> 
>

applied, thanks!




      parent reply	other threads:[~2021-05-03 13:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-06 10:41 [pve-devel] " Fabian Ebner
2021-04-06 10:41 ` [pve-devel] [PATCH v4 manager 2/3] ui: backup: fill in some of the " Fabian Ebner
2021-05-03 13:02   ` [pve-devel] applied: " Thomas Lamprecht
2021-04-06 10:41 ` [pve-devel] [PATCH v4 manager 3/3] fix #2745: ui: backup: allow specifying remove parameter for manual backup Fabian Ebner
2021-05-03 13:02 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6ee23298-7166-878c-20d9-8a21bd48da79@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal