public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Fabian Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied-series:  [PATCH-SERIES v3] migration tests
Date: Tue, 15 Dec 2020 16:20:56 +0100	[thread overview]
Message-ID: <6eddab54-aae2-b7a4-6058-cdcd20d81f45@proxmox.com> (raw)
In-Reply-To: <20201201120702.3869-1-f.ebner@proxmox.com>

On 01.12.20 13:06, Fabian Ebner wrote:
> Refactor some code and create a test enviroment for migration. See the last
> patch for a description of the latter.
> 
> The first two patches depend on libpve-guest-common-perl >=3.1-3
> 
> Changes from v2:
>     * drop already applied patch introducing move_config_to_node helper
>     * rebase on current master and verify tests still behave the same
>       way (they did, but it's not surprising as QemuMigrate.pm didn't
>       change much since v2 was sent).
>     * add a patch to sort volumes migrated with storage_migrate and adapt
>       affected test
> 
> 
> container:
> 
> Fabian Ebner (1):
>   use new move_config_to_node method
> 
>  src/PVE/LXC/Migrate.pm | 12 ++----------
>  1 file changed, 2 insertions(+), 10 deletions(-)
> 
> 
> qemu-server:
> 
> Fabian Ebner (4):
>   use new move_config_to_node method
>   migration: factor out starting remote tunnel
>   migration: sort volumes migrated with storage_migrate
>   create test environment for migration
> 
>  PVE/QemuMigrate.pm                    |  130 +-
>  test/Makefile                         |    5 +-
>  test/MigrationTest/QemuMigrateMock.pm |  319 +++++
>  test/MigrationTest/QmMock.pm          |  142 +++
>  test/MigrationTest/Shared.pm          |  170 +++
>  test/run_qemu_migrate_tests.pl        | 1594 +++++++++++++++++++++++++
>  6 files changed, 2295 insertions(+), 65 deletions(-)
>  create mode 100644 test/MigrationTest/QemuMigrateMock.pm
>  create mode 100644 test/MigrationTest/QmMock.pm
>  create mode 100644 test/MigrationTest/Shared.pm
>  create mode 100755 test/run_qemu_migrate_tests.pl
> 



applied series, thanks!

The tests for qemu add ~ 36s of build time, which is rather much for that package.
Can you look into this, maybe we can move the tests to single .json file snippets
and do them in parallel through the make buildsystem.





      parent reply	other threads:[~2020-12-15 15:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-01 12:06 [pve-devel] " Fabian Ebner
2020-12-01 12:06 ` [pve-devel] [PATCH v3 container 1/5] use new move_config_to_node method Fabian Ebner
2020-12-01 12:06 ` [pve-devel] [PATCH v3 qemu-server 2/5] " Fabian Ebner
2020-12-01 12:07 ` [pve-devel] [PATCH v3 qemu-server 3/5] migration: factor out starting remote tunnel Fabian Ebner
2020-12-01 12:07 ` [pve-devel] [PATCH v3 qemu-server 4/5] migration: sort volumes migrated with storage_migrate Fabian Ebner
2020-12-01 12:07 ` [pve-devel] [PATCH v3 qemu-server 5/5] create test environment for migration Fabian Ebner
2020-12-15 15:20 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6eddab54-aae2-b7a4-6058-cdcd20d81f45@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal