From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Christoph Heiss <c.heiss@proxmox.com>
Subject: Re: [pve-devel] [PATCH installer 0/2] expose zfs arc size setting for all products
Date: Tue, 6 Feb 2024 13:49:36 +0100 [thread overview]
Message-ID: <6ecd03ab-1420-4766-9505-c3a6cae5cf87@proxmox.com> (raw)
In-Reply-To: <20231130100147.233793-1-c.heiss@proxmox.com>
Am 30/11/2023 um 11:01 schrieb Christoph Heiss:
> As suggested by Thomas, sets the default to 50% for all non-PVE
> products.
>
> Quickly smoke-tested this, to see if all installer show the correct
> value in the GUI/TUI.
What I'm wondering if we should skip actively setting this as module
parameter if the user did not changed the value at all?
That way it would stay dynamic, e.g., if one increased the memory of
a PBS or PMG instance, but one could also interpret that as bad thing,
especially if the MiB number was shown.
For GTK we could just go for a placeholder text showing the number,
but there isn't really such a UX-mechanic available for the TUI one
AFAICT.
Anyhow, I can be OK with always hard-coding, just wanted to know
your (or others) thoughts on this.
next prev parent reply other threads:[~2024-02-06 12:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 10:01 Christoph Heiss
2023-11-30 10:01 ` [pve-devel] [PATCH installer 1/2] tui: expose arc size setting for zfs bootdisks " Christoph Heiss
2023-11-30 10:01 ` [pve-devel] [PATCH installer 2/2] proxinstall: " Christoph Heiss
2024-01-24 9:52 ` [pve-devel] [PATCH installer 0/2] expose zfs arc size setting " Christoph Heiss
2024-02-06 12:49 ` Thomas Lamprecht [this message]
2024-02-06 13:25 ` Christoph Heiss
2024-02-06 13:41 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ecd03ab-1420-4766-9505-c3a6cae5cf87@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox