From: Stefan Sterz <s.sterz@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Thomas Lamprecht <t.lamprecht@proxmox.com>,
Wolfgang Bumiller <w.bumiller@proxmox.com>
Subject: Re: [pve-devel] applied: [PATCH 1/3] Revert "dark-theme: let the background "shine through" mask more"
Date: Tue, 21 Mar 2023 15:04:53 +0100 [thread overview]
Message-ID: <6eacf96a-c3ad-b71c-131b-285b9d323b50@proxmox.com> (raw)
In-Reply-To: <1546649a-2aef-7262-d221-a374d670a11c@proxmox.com>
On 3/21/23 14:05, Thomas Lamprecht wrote:
> Am 21/03/2023 um 11:04 schrieb Wolfgang Bumiller:
>> This looks horrible.
>>
>> A *much* *much* better way to improve readability is to
>> simply set the opacity down to 0.5.
>>
>> This reverts commit 2c837f5766b48629a835c62d4b7af6c3ae4dc1c0.
>> ---
>> I can't stand this.
>> Seriously.
>>
>> src/proxmox-dark/scss/extjs/_presentation.scss | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>>
>
> applied all three patches, they actually fulfil my request to be able to still
> read the stuff in the bg even a bit better and look fine enough otherwise, thanks!
>
> FWIW, just from a aesthetic POV the best way to make modal windows stand out would
> be to blur the background, i.e.:
>
> .x-mask {
> background-color: rgba(0,0,0,0.5);
> backdrop-filter: blur(2px);
> }
>
> (backdrop-filter + opacity doesn't work, so one needs to use rgba instead)
>
> But I prefer usability/accessibility over aesthetics here.
>
well rgba values sadly don't work properly with sassc. so that will
become a solid black background.
also as discussed off-list, setting the background of the mask to black
looks awkward/less consistent with crisp in several situation (e.g., the
retention tab of a zfs storage or the quarantine mail preview panel).
however @Wolfgang and i agreed on the following:
.x-mask {
background-color: $background-darker;
opacity: 0.5;
}
.x-css-shadow {
box-shadow: black 0 -1px 15px 5px !important;
}
that should hopefully fullfill all three requirements (see-through,
contrast to background, not looking strange in the given situations).
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
prev parent reply other threads:[~2023-03-21 14:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 10:04 [pve-devel] " Wolfgang Bumiller
2023-03-21 10:04 ` [pve-devel] [PATCH 2/3] dark-mode: reduce background mask opacity to 0.5 Wolfgang Bumiller
2023-03-21 10:04 ` [pve-devel] [PATCH 3/3] dark-mode: make shadow black Wolfgang Bumiller
2023-03-21 13:05 ` [pve-devel] applied: [PATCH 1/3] Revert "dark-theme: let the background "shine through" mask more" Thomas Lamprecht
2023-03-21 14:04 ` Stefan Sterz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6eacf96a-c3ad-b71c-131b-285b9d323b50@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox