From: Aaron Lauterer <a.lauterer@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager v2 0/6] fix #1408: ui: make tree sorting configurable
Date: Thu, 9 Feb 2023 11:34:44 +0100 [thread overview]
Message-ID: <6ea95200-6304-2060-0ac0-f14830984fc4@proxmox.com> (raw)
In-Reply-To: <20230202144135.3892582-1-d.csapak@proxmox.com>
Had two small nits in patch 5/6. Otherwise it seems to work nicely. Tested all
options and also had tags with tag overrides configured in my tests.
Consider this
Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>
On 2/2/23 15:41, Dominik Csapak wrote:
> this series allows configuring the sorting of the resource tree
>
> options are the sort-field, if guest types are grouped and if templates
> are grouped seperately. it's configurable via browser local storage
>
> the first 2 patches are not really related but popped up during
> development
>
> changes from v1:
> * drop the datacenter config options for now
> * rename TreeSortingEdit into TreeSortingEdit
> * since we don't have a fallback besides the default, display the
> defauls in the dropdowns
> * don't use booleanfield anymore (because of above change)
> * rename sp into localStorage
> * use fieldDefaults
> * refactor stuff into PVE.UIOptions (a new singleton)
> * remove storage view
> * remove booleanfield
>
> Dominik Csapak (6):
> ui: remove 'Storage View'
> ui: remove unused booleanfield
> ui: refactor ui option related methods into UIOptions
> ui: refactor refreshing the the resource store/tree
> ui: add window for changing tree related options
> fix #1408: ui: ResourceTree: sort the tree according to tree-sorting
> options
>
> www/manager6/Makefile | 3 +-
> www/manager6/UIOptions.js | 107 ++++++++++++++++++++++++
> www/manager6/Utils.js | 92 +-------------------
> www/manager6/Workspace.js | 28 ++++++-
> www/manager6/data/ResourceStore.js | 2 +-
> www/manager6/dc/OptionView.js | 23 ++---
> www/manager6/form/Boolean.js | 10 ---
> www/manager6/form/GlobalSearchField.js | 2 +-
> www/manager6/form/Tag.js | 6 +-
> www/manager6/form/TagColorGrid.js | 2 +-
> www/manager6/form/TagEdit.js | 10 +--
> www/manager6/form/ViewSelector.js | 7 --
> www/manager6/tree/ResourceTree.js | 56 ++++++++++---
> www/manager6/window/TreeSettingsEdit.js | 87 +++++++++++++++++++
> 14 files changed, 289 insertions(+), 146 deletions(-)
> create mode 100644 www/manager6/UIOptions.js
> delete mode 100644 www/manager6/form/Boolean.js
> create mode 100644 www/manager6/window/TreeSettingsEdit.js
>
prev parent reply other threads:[~2023-02-09 10:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-02 14:41 Dominik Csapak
2023-02-02 14:41 ` [pve-devel] [PATCH manager v2 1/6] ui: remove 'Storage View' Dominik Csapak
2023-02-09 16:22 ` Thomas Lamprecht
2023-02-02 14:41 ` [pve-devel] [PATCH manager v2 2/6] ui: remove unused booleanfield Dominik Csapak
2023-02-02 14:41 ` [pve-devel] [PATCH manager v2 3/6] ui: refactor ui option related methods into UIOptions Dominik Csapak
2023-02-02 14:41 ` [pve-devel] [PATCH manager v2 4/6] ui: refactor refreshing the the resource store/tree Dominik Csapak
2023-02-02 14:41 ` [pve-devel] [PATCH manager v2 5/6] ui: add window for changing tree related options Dominik Csapak
2023-02-09 10:33 ` Aaron Lauterer
2023-02-02 14:41 ` [pve-devel] [PATCH manager v2 6/6] fix #1408: ui: ResourceTree: sort the tree according to tree-sorting options Dominik Csapak
2023-02-09 10:34 ` Aaron Lauterer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ea95200-6304-2060-0ac0-f14830984fc4@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox