Re: [pve-devel] [PATCH pve-installer 2/6] common: use get_min_disks as single source of truth for RAID config checks

From: "Michael Köppl" <m.koeppl@proxmox.com>
To: Christoph Heiss <c.heiss@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-installer 2/6] common: use get_min_disks as single source of truth for RAID config checks
Date: Mon, 28 Apr 2025 17:36:06 +0200	[thread overview]
Message-ID: <6e6c3c44-068e-4ed2-a392-3272df6965e3@proxmox.com> (raw)
In-Reply-To: <D9I8YBEQNI7O.EBSGAABFFSEB@proxmox.com>

On 4/28/25 13:48, Christoph Heiss wrote:
>>
>>   proxmox-installer-common/src/disk_checks.rs | 18 ++++--------------
>>   1 file changed, 4 insertions(+), 14 deletions(-)
>>
>> diff --git a/proxmox-installer-common/src/disk_checks.rs b/proxmox-installer-common/src/disk_checks.rs
>> index ecc43bd..1d17e2c 100644
>> --- a/proxmox-installer-common/src/disk_checks.rs
>> +++ b/proxmox-installer-common/src/disk_checks.rs
>> @@ -69,17 +69,16 @@ pub fn check_zfs_raid_config(level: ZfsRaidLevel, disks: &[Disk]) -> Result<(),
> 
> While looking at all the disks checks, most of them could be made
> methods of the respective enum, e.g. so one could do something like
> `ZfsRaidLevel::Raid1.check_disks(disks)`.
> 
> What do you think? Would be a nice cleanup (via a separate series would
> also be okay, of course).

I think it's a good idea, already working on it. I'll add it to the v2. 
Thanks for the suggestion!

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel