From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Leo Nunner <l.nunner@proxmox.com>,
Wolfgang Bumiller <w.bumiller@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server] cloudinit: fix 'pending' api endpoint
Date: Wed, 7 Jun 2023 18:36:58 +0200 [thread overview]
Message-ID: <6e5b0ca2-9ce3-acfe-0b26-4973b84ce91f@proxmox.com> (raw)
In-Reply-To: <20230511080317.49367-1-l.nunner@proxmox.com>
Am 11/05/2023 um 10:03 schrieb Leo Nunner:
> This patch partially reverts commit 1b5706cd168fedc5e494e24300069ee4ff25761f,
> by reintroducing the old format for return values (key, value, pending,
> delete), but drops the "force-delete" return value. Right now, this
> endpoint does not conform to its own format, because the return values
> are as follows:
>
> {
> key => {
> old => 'foo',
> new => 'bar',
> },
> […]
> }
>
> While the format specified is
>
> [
> {
> key => 'baz',
> old => 'foo',
> new => 'bar',
> },
> […]
> ]
>
> This leads to the endpoint being broken when used through 'qm' and
> 'pvesh'. Using the API works fine, because the format doesn't get
> verified there. Reverting this change brings the advantage that we can
> also use PVE::GuestHelpers::format_pending when calling the endpoint
> through qm again.
>
> Signed-off-by: Leo Nunner <l.nunner@proxmox.com>
> ---
> I'm not sure whether or not this constitutes a breaking change. We are
> returning to the old format for this endpoint, and up until now it was
> broken anyway (well, for the CLI that is).
>
> PVE/API2/Qemu.pm | 48 ++++++++++++++++++++++++++++++++++--------------
> 1 file changed, 34 insertions(+), 14 deletions(-)
>
>
applied, thanks! BUT, mainly @Wolfgang, I thought we figured that out ok back then,
can you re-check this please, I'd really like to stop this from coming back haunting
us 👻
prev parent reply other threads:[~2023-06-07 16:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-11 8:03 [pve-devel] " Leo Nunner
2023-06-07 16:36 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e5b0ca2-9ce3-acfe-0b26-4973b84ce91f@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=l.nunner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox