From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Fabian Ebner <f.ebner@proxmox.com>,
pve-devel@lists.proxmox.com,
Stefan Hrdlicka <s.hrdlicka@proxmox.com>
Subject: Re: [pve-devel] [PATCH V2 manager 2/3] cleanup: "var" to "let", fix some indentation in related files
Date: Tue, 28 Jun 2022 15:10:33 +0200 [thread overview]
Message-ID: <6ddfec09-beb6-b9de-2488-4a39d07d6296@proxmox.com> (raw)
In-Reply-To: <bb116765-f635-11ac-d046-222ce31256b6@proxmox.com>
On 28/06/2022 12:54, Fabian Ebner wrote:
> Am 22.06.22 um 16:39 schrieb Stefan Hrdlicka:
>> replace all "var" with "let" in files related to patch for ticket 2822
>>
>> Signed-off-by: Stefan Hrdlicka <s.hrdlicka@proxmox.com>
>
> While this patch can be fine, I think the next one is a bit too big ;)
> It might introduce subtle bugs (since we might be relying on the
> semantics of var somewhere) and I'd rather continue having the
> conversion be done organically for a while, with patches limited in
> scope (pun intended) like this one being okay.
>
> @Dominik, @Thomas opinions?
+1
Such general and (semi-)automatable cleanups are IMO better applied by
maintainers directly, they can push out a quick fix if anything is off
and often are much more experienced in the code base to have a feeling
where it actually has a benefit (parts seeing more churn) and how safe
it is wrt. to side effects.
next prev parent reply other threads:[~2022-06-28 13:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 14:39 [pve-devel] [PATCH V2 manager 0/3] add iscsi, lvm, lvmthin & zfs storage on all cluster nodes Stefan Hrdlicka
2022-06-22 14:39 ` [pve-devel] [PATCH V2 manager 1/3] fix #2822: add iscsi, lvm, lvmthin & zfs storage for " Stefan Hrdlicka
2022-06-28 10:33 ` Fabian Ebner
[not found] ` <779a3434-e2a9-c92a-56b1-625346dcf1d4@proxmox.com>
2022-07-19 6:50 ` Fabian Ebner
2022-06-22 14:39 ` [pve-devel] [PATCH V2 manager 2/3] cleanup: "var" to "let", fix some indentation in related files Stefan Hrdlicka
2022-06-28 10:54 ` Fabian Ebner
2022-06-28 13:10 ` Thomas Lamprecht [this message]
2022-06-22 14:39 ` [pve-devel] [PATCH V2 manager 3/3] cleanup: "var" to "let" in all javascript files Stefan Hrdlicka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ddfec09-beb6-b9de-2488-4a39d07d6296@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.hrdlicka@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox