From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Christoph Heiss <c.heiss@proxmox.com>
Subject: [pve-devel] applied: [PATCH v2 qemu-server 1/3] vzdump: Add VM QGA option to skip fs-freeze/-thaw on backup
Date: Thu, 23 Feb 2023 16:36:36 +0100 [thread overview]
Message-ID: <6dcec81f-dbb0-3728-0599-ae52d38006b9@proxmox.com> (raw)
In-Reply-To: <20230223141805.446192-2-c.heiss@proxmox.com>
Am 23/02/2023 um 15:18 schrieb Christoph Heiss:
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
> Changes v1 -> v2:
> * Rename option from 'fsfreeze_thaw' to 'freeze-fs-on-backup'
> * Adapt option description as suggested
> * Fix option check in qga_fs_freeze()
>
> PVE/QemuServer.pm | 8 +++++++-
> PVE/VZDump/QemuServer.pm | 6 ++++++
> 2 files changed, 13 insertions(+), 1 deletion(-)
>
>
applied, thanks!
FWIW, I forgot to write in my review of v1 that having the disabled-in-config
check done before the is-qga-running one would have felt _slightly_ more sensible
to me, as no use in checking for availability of a service if one isn't going
to use it anyway - but, this is only a small nit and could be easily addressed
anytime - so mostly mentioning it to get it off my mind ;-)
next prev parent reply other threads:[~2023-02-23 15:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 14:18 [pve-devel] [PATCH v2 qemu-server/manager/docs 0/3] fix #4140: Add option to disable QGA " Christoph Heiss
2023-02-23 14:18 ` [pve-devel] [PATCH v2 qemu-server 1/3] vzdump: Add VM QGA option to skip " Christoph Heiss
2023-02-23 15:36 ` Thomas Lamprecht [this message]
2023-02-23 14:18 ` [pve-devel] [PATCH v2 manager 2/3] ui: qga: Add option to turn off QGA " Christoph Heiss
2023-03-21 12:31 ` Thomas Lamprecht
2023-03-21 12:49 ` Christoph Heiss
2023-02-23 14:18 ` [pve-devel] [PATCH v2 docs 3/3] qm: Add section explaining fs-freeze/-thaw QGA option Christoph Heiss
2023-03-21 10:53 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6dcec81f-dbb0-3728-0599-ae52d38006b9@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox