From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager] ui: storage: esxi: check 'skip certificate verification' by default
Date: Thu, 21 Mar 2024 18:07:08 +0100 [thread overview]
Message-ID: <6d30f4d4-8268-4e32-bc58-4d3cc0a4651f@proxmox.com> (raw)
In-Reply-To: <20240320153921.3151412-1-d.csapak@proxmox.com>
On 20/03/2024 16:39, Dominik Csapak wrote:
> needing one less step when adding the storage, assuming most esxi
> certificates are self-signed.
Well this makes it insecure by default though? Which is not something
I'd just not mention in such a commit message...
As that was the original reason I ticked it in the first place
when pondering between security and convenience...
If we do this I'd rather rename it to "Check Certificate" and have
that unticked.
Even better would be to be able to pass a finger-print, which was our
first idea, but Wolfgang found that the esxi python wrapper is to
enterprisy to hook into basic TLS validation, and he also rejected
proxying..
next prev parent reply other threads:[~2024-03-21 17:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 15:39 Dominik Csapak
2024-03-21 17:07 ` Thomas Lamprecht [this message]
2024-03-22 7:29 ` Dominik Csapak
2024-03-22 8:46 ` Thomas Lamprecht
2024-03-22 9:07 ` Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d30f4d4-8268-4e32-bc58-4d3cc0a4651f@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox