Re: [pve-devel] [PATCH manager] pveceph: add ecpool create wrapper for the CLI

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

On 29.04.22 09:39, Dominik Csapak wrote:
> that exposes the ec options as seperate parameters instead of a format string
> (for convenience). I made the ceph_pool_common_options and ec_format
> public so that we can reuse them for that
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> @Thomas, because you suggested something like that, but it seems a bit
> out of place to me, and giving the options as property-string is not too
> bad, e.g.
> 
> pveceph pool create poolname --erasure-coding k=2,m2
> 
> vs
> 
> pveceph ecpool create poolname 2 2


I mean, I'd have done:

pveceph ec-pool create poolname -k 2 -m 2

which is a bit more telling than using fixed options for k/m but anyhow, you may be
right in that the format string isn't to bad after all for the CLI too, and avoiding
extra commands can have its merits as it reduces complexity in some way too.

So its fine for me as is, minus the missing docs naturally ;-P