From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>
Subject: Re: [pve-devel] [RFC common/manager/qemu-server 0/5] fix #3900: schema: support and prefer sizes with verbose suffixes {K, M, G, T}iB
Date: Sun, 1 Jun 2025 11:51:10 +0200 [thread overview]
Message-ID: <6d03512f-1fea-45c2-870e-5daf9bdf86e1@proxmox.com> (raw)
In-Reply-To: <98be9bd7-5a39-445e-9854-b9b9e44644f2@proxmox.com>
Am 12.05.25 um 15:00 schrieb Fiona Ebner:
> Am 12.05.25 um 14:41 schrieb Fiona Ebner:
>> Maybe best is to wait for PVE 9 with this and do a parse+write for all
>> guest configs (including their snapshots) in the pve8to9 script? The
>> change also breaks backwards migration to a node that doesn't
>> understand the new suffix.
>
> If we decide on that, I'll split the patch common 1/5 into two, since we
> already need the parsing support in PVE 8 (or we couldn't rewrite in
> pve8to9). And in PVE 9, we can switch to writing with the verbose
> suffixes by default.
Saw this reply only later; yeah, please split this up and NACK form my
side for such a rewrites in 8to9 checker script.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-06-01 9:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-12 12:41 Fiona Ebner
2025-05-12 12:41 ` [pve-devel] [PATCH common 1/5] " Fiona Ebner
2025-06-01 9:48 ` Thomas Lamprecht
2025-05-12 12:41 ` [pve-devel] [PATCH manager 2/5] vzdump: use verbose size suffix when logging archive file size Fiona Ebner
2025-05-12 12:41 ` [pve-devel] [PATCH manager 3/5] test: adapt tests to use verbose disk size suffixes Fiona Ebner
2025-05-12 12:41 ` [pve-devel] [PATCH qemu-server 4/5] test: fix tests for changes when printing disk size suffix Fiona Ebner
2025-05-12 12:41 ` [pve-devel] [PATCH qemu-server 5/5] test: adapt all tests to use verbose disk size suffixes Fiona Ebner
2025-05-12 13:00 ` [pve-devel] [RFC common/manager/qemu-server 0/5] fix #3900: schema: support and prefer sizes with verbose suffixes {K, M, G, T}iB Fiona Ebner
2025-06-01 9:51 ` Thomas Lamprecht [this message]
2025-06-02 11:21 ` Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d03512f-1fea-45c2-870e-5daf9bdf86e1@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal