From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com,
Lorenz Stechauner <l.stechauner@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager 2/2] fix 3850: ui: storage: using PreallocationSelector for file based storage types
Date: Tue, 14 Sep 2021 11:55:04 +0200 [thread overview]
Message-ID: <6ce52199-a828-6c60-b693-d083dde0e211@proxmox.com> (raw)
In-Reply-To: <20210906131542.178844-4-l.stechauner@proxmox.com>
Am 06.09.21 um 15:15 schrieb Lorenz Stechauner:
> Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
> ---
> www/manager6/controller/StorageEdit.js | 6 ++++++
> www/manager6/storage/Base.js | 18 ++++++++++++++++++
> 2 files changed, 24 insertions(+)
>
> diff --git a/www/manager6/controller/StorageEdit.js b/www/manager6/controller/StorageEdit.js
> index 4246d363..cb73b776 100644
> --- a/www/manager6/controller/StorageEdit.js
> +++ b/www/manager6/controller/StorageEdit.js
> @@ -4,6 +4,12 @@ Ext.define('PVE.controller.StorageEdit', {
> control: {
> 'field[name=content]': {
> change: function(field, value) {
> + const hasImages = Ext.Array.contains(value, 'images');
> + const prealloc = field.up('form').getForm().findField('preallocation');
> + if (prealloc) {
> + prealloc.setDisabled(!hasImages);
> + }
> +
> var hasBackups = Ext.Array.contains(value, 'backup');
> var maxfiles = this.lookupReference('maxfiles');
> if (!maxfiles) {
> diff --git a/www/manager6/storage/Base.js b/www/manager6/storage/Base.js
> index ee8b54e8..457576a3 100644
> --- a/www/manager6/storage/Base.js
> +++ b/www/manager6/storage/Base.js
> @@ -51,6 +51,24 @@ Ext.define('PVE.panel.StorageBase', {
> },
> );
>
> + const fileBasedStorageTypes = ['dir', 'btrfs', 'nfs', 'cifs', 'glusterfs'];
Nit: CephFS is also file-based. What about using qemuImgStorageTypes or
if (['dir',...].includes(me.type)) directly?
> +
> + if (fileBasedStorageTypes.includes(me.type)) {
> + const preallocSelector = {
> + xtype: 'pvePreallocationSelector',
> + name: 'preallocation',
> + fieldLabel: gettext('Preallocation'),
> + allowBlank: false,
> + value: 'default',
> + };
> +
> + // ensures, that the PreallocationSelector is always on the left side
> + if (me.advancedColumn1) {
> + me.advancedColumn2 = me.advancedColumn1;
Why does it need to be on the left side? What if there already is an
advancedColumn2?
> + }
> + me.advancedColumn1 = [preallocSelector];
> + }
> +
> me.callParent();
> },
> });
>
prev parent reply other threads:[~2021-09-14 9:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-06 13:15 [pve-devel] [PATCH-SERIES storage/manager] fix #3580: make preallocation mode selectable for qcow2 and raw images Lorenz Stechauner
2021-09-06 13:15 ` [pve-devel] [PATCH storage 1/1] fix #3580: plugins: " Lorenz Stechauner
2021-09-08 8:11 ` alexandre derumier
2021-09-09 10:25 ` Fabian Ebner
2021-09-09 11:11 ` Lorenz Stechauner
2021-09-09 12:04 ` Fabian Ebner
2021-09-09 12:26 ` Lorenz Stechauner
2021-09-09 12:28 ` Thomas Lamprecht
2021-09-14 9:44 ` Fabian Ebner
2021-09-06 13:15 ` [pve-devel] [PATCH manager 1/2] ui: add PreallocationSelector Lorenz Stechauner
2021-09-06 13:15 ` [pve-devel] [PATCH manager 2/2] fix 3850: ui: storage: using PreallocationSelector for file based storage types Lorenz Stechauner
2021-09-14 9:55 ` Fabian Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ce52199-a828-6c60-b693-d083dde0e211@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=l.stechauner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox