From: Aaron Lauterer <a.lauterer@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH widget-toolkit 3/3] fix #3892: NetworkEdit: add bridge vids field for bridge_vids
Date: Fri, 2 Jun 2023 15:10:24 +0200 [thread overview]
Message-ID: <6c903c4b-e105-5063-118c-882d7df2cbc9@proxmox.com> (raw)
In-Reply-To: <1e556951-4c24-0451-459e-802586f3aed7@proxmox.com>
On 6/1/23 16:24, Thomas Lamprecht wrote:
> Don't we reuse that on PBS/PMG too, and if is it working there?
>
> The commit message isn't excactly telling... ;-)
>
on PMG we only allow creating bonds in the GUI. On PBS we allow bonds and
bridges. Though that makes we wonder what the use case for a bridge on PBS is.
What about safeguarding the vids to only be added/used if we are on PVE?
Something like `if (PVE) {`?
>
> Am 13/04/2023 um 17:10 schrieb Aaron Lauterer:
>> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
>> ---
>> src/node/NetworkEdit.js | 16 ++++++++++++++++
>> 1 file changed, 16 insertions(+)
>>
>> diff --git a/src/node/NetworkEdit.js b/src/node/NetworkEdit.js
>> index bb9add3..e4ab158 100644
>> --- a/src/node/NetworkEdit.js
>> +++ b/src/node/NetworkEdit.js
>> @@ -57,11 +57,26 @@ Ext.define('Proxmox.node.NetworkEdit', {
>> }
>>
>> if (me.iftype === 'bridge') {
>> + let vids = Ext.create('Ext.form.field.Text', {
>> + fieldLabel: gettext('Bridge VIDS'),
>> + name: 'bridge_vids',
>> + emptyText: '2-4094',
>> + disabled: true,
>> + autoEl: {
>> + tag: 'div',
>> + 'data-qtip': gettext('Space-separated list of VLANs and ranges, for example: 2 4 100-200'),
>> + },
>> + });
>> column2.push({
>> xtype: 'proxmoxcheckbox',
>> fieldLabel: gettext('VLAN aware'),
>> name: 'bridge_vlan_aware',
>> deleteEmpty: !me.isCreate,
>> + listeners: {
>> + change: function(f, newVal) {
>> + vids.setDisabled(!newVal);
>> + },
>> + },
>> });
>> column2.push({
>> xtype: 'textfield',
>> @@ -72,6 +87,7 @@ Ext.define('Proxmox.node.NetworkEdit', {
>> 'data-qtip': gettext('Space-separated list of interfaces, for example: enp0s0 enp1s0'),
>> },
>> });
>> + advancedColumn2.push(vids);
>> } else if (me.iftype === 'OVSBridge') {
>> column2.push({
>> xtype: 'textfield',
>
next prev parent reply other threads:[~2023-06-02 13:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 15:10 [pve-devel] [PATCH common 1/3] fix #3893: network: make bridge vids configurable Aaron Lauterer
2023-04-13 15:10 ` [pve-devel] [PATCH manager 2/3] fix #3893: api: network: add bridge_vids parameter Aaron Lauterer
2023-04-13 15:10 ` [pve-devel] [PATCH widget-toolkit 3/3] fix #3892: NetworkEdit: add bridge vids field for bridge_vids Aaron Lauterer
2023-06-01 14:24 ` Thomas Lamprecht
2023-06-02 13:10 ` Aaron Lauterer [this message]
2023-06-07 16:12 ` Thomas Lamprecht
2023-05-26 8:33 ` [pve-devel] [PATCH common 1/3] fix #3893: network: make bridge vids configurable Aaron Lauterer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c903c4b-e105-5063-118c-882d7df2cbc9@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox