From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Christian Ebner <c.ebner@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH v2 pve-manager pve-docs 0/4] add optional WoL config options
Date: Thu, 28 Mar 2024 18:27:25 +0100 [thread overview]
Message-ID: <6c8f7a40-98b1-47dd-b981-08562ef59a49@proxmox.com> (raw)
In-Reply-To: <20240326091659.63483-1-c.ebner@proxmox.com>
Am 26/03/2024 um 10:16 schrieb Christian Ebner:
> For certain network setups the default values currently used to send
> a wake on lan magic packet are not correct, e.g. it will get send via
> the interface for which the default gateway is configured.
>
> This patches add optional configuration options to set a bind
> interface, over which to send the WoL packet and/or set a broadcast
> address to use.
>
> The functionality was tested by listening on all interfaces of the
> sending host via `tcpdump -i any udp port 9`, and testing the
> combinations of
>
> `pvenode config set -wakeonlan XX:XX:XX:XX:XX:XX,bind-interface=<iface-name>`
>
> and
>
> `pvenode config set -wakeonlan XX:XX:XX:XX:XX:XX,broadcast-address=<broadcast-address>`.
>
> See also the thread in the community forum
> https://forum.proxmox.com/threads/123459/
>
> pve-manager:
>
> Christian Ebner (3):
> node: config: make wakeonlan a property string
> fix #5255: node: wol: add optional bind interface
> fix #5255: node: wol: configurable broadcast address
>
> PVE/API2/Nodes.pm | 23 ++++++++++++++++----
> PVE/NodeConfig.pm | 53 +++++++++++++++++++++++++++++++++++++++++------
> 2 files changed, 66 insertions(+), 10 deletions(-)
>
> pve-docs:
>
> Christian Ebner (1):
> pvenode/wake-on-lan: mention optional config options
>
> pvenode.adoc | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
applied, thanks!
I did some very minor follow-ups mostly to document the current default in
the schema and docs and a small style fix (well not even really style wise,
but rather making the part with assigning and checking the $bind_interface
variable slightly shorter).
While this is slightly niche it might still make sense to add this to the
web UI too (WoL is exposed via Node -> Options) for completeness sake.
next prev parent reply other threads:[~2024-03-28 17:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 9:16 [pve-devel] " Christian Ebner
2024-03-26 9:16 ` [pve-devel] [PATCH v2 pve-manager 1/4] node: config: make wakeonlan a property string Christian Ebner
2024-03-26 9:16 ` [pve-devel] [PATCH v2 pve-manager 2/4] fix #5255: node: wol: add optional bind interface Christian Ebner
2024-03-26 9:16 ` [pve-devel] [PATCH v2 pve-manager 3/4] fix #5255: node: wol: configurable broadcast address Christian Ebner
2024-03-26 9:16 ` [pve-devel] [PATCH v2 pve-docs 4/4] pvenode/wake-on-lan: mention optional config options Christian Ebner
2024-03-28 17:27 ` Thomas Lamprecht [this message]
2024-03-29 7:44 ` [pve-devel] applied-series: [PATCH v2 pve-manager pve-docs 0/4] add optional WoL " Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c8f7a40-98b1-47dd-b981-08562ef59a49@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox