From: Lorenz Stechauner <l.stechauner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH widget-toolkit/manager] unify gui for task listing
Date: Mon, 28 Jun 2021 11:45:55 +0200 [thread overview]
Message-ID: <6b93ce16-35f9-b00d-b5bb-3df5d284ebe7@proxmox.com> (raw)
In-Reply-To: <20210624071618.21507-1-d.csapak@proxmox.com>
Tested VM & node task log. Works as expected
But found some minor inconveniences:
* When a task is selected and the filter changes, therefore this task is
not visible anymore, it is possible to click on the "view" button and
see the previously selected task. Better behavior would be to clear the
selection if the selected task is not visible anymore.
* Improvement/suggestion: somehow show the task description to the user
when selecting the task type (either combo box or "imgdel (Erase Data)"
format?)
Tested-By: Lorenz Stechauner <l.stechauner@proxmox.com>
On 24.06.21 09:16, Dominik Csapak wrote:
> ports over the new task listing we have in pbs to widget-toolkit,
> which is used in pve/pmg
>
> for this to work, the previous api series[0] must be applied,
> otherwise the filter parameter do not exist
>
> 0: https://lists.proxmox.com/pipermail/pve-devel/2021-June/048989.html
>
> proxmox-widget-toolkit:
>
> Dominik Csapak (1):
> node/Tasks: merge improvements from PBS and make it more generic
>
> src/css/ext6-pmx.css | 4 +
> src/node/Tasks.js | 578 ++++++++++++++++++++++++++++++-------------
> 2 files changed, 411 insertions(+), 171 deletions(-)
>
> pve-manager:
>
> Dominik Csapak (2):
> {qemu,lxc}/Config: adapt to new proxmoxNodeTasks
> ui: node/Config: add vmid filter to task lists
>
> www/manager6/lxc/Config.js | 4 +++-
> www/manager6/node/Config.js | 8 ++++++++
> www/manager6/qemu/Config.js | 4 +++-
> 3 files changed, 14 insertions(+), 2 deletions(-)
>
next prev parent reply other threads:[~2021-06-28 9:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 7:16 Dominik Csapak
2021-06-24 7:16 ` [pve-devel] [PATCH widget-toolkit 1/1] node/Tasks: merge improvements from PBS and make it more generic Dominik Csapak
2021-06-28 15:47 ` [pve-devel] applied: " Thomas Lamprecht
2021-06-24 7:16 ` [pve-devel] [PATCH manager 1/2] {qemu, lxc}/Config: adapt to new proxmoxNodeTasks Dominik Csapak
2021-06-28 15:53 ` [pve-devel] applied: " Thomas Lamprecht
2021-06-24 7:16 ` [pve-devel] [PATCH manager 2/2] ui: node/Config: add vmid filter to task lists Dominik Csapak
2021-06-28 15:53 ` [pve-devel] applied: " Thomas Lamprecht
2021-06-28 9:45 ` Lorenz Stechauner [this message]
2021-06-28 15:58 ` [pve-devel] [PATCH widget-toolkit/manager] unify gui for task listing Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b93ce16-35f9-b00d-b5bb-3df5d284ebe7@proxmox.com \
--to=l.stechauner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox