From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fabian Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH v2 manager] ui: lxc options: disable features edit as non-root when container is privileged
Date: Wed, 16 Mar 2022 16:24:06 +0100 [thread overview]
Message-ID: <6b915aa7-838c-4acf-5f02-6c51b8be9869@proxmox.com> (raw)
In-Reply-To: <20210813091012.29410-1-f.ebner@proxmox.com>
On 13.08.21 11:10, Fabian Ebner wrote:
> The backend won't allow any edits in this case, so better just disable
> the edit button altogether.
>
> Co-developed-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>
> Changes from v1:
> * split cases based on 'key'
> * keep logic for {dis,en}abling edit button for features in one
> place
>
> www/manager6/lxc/Options.js | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2022-03-16 15:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-13 9:10 [pve-devel] " Fabian Ebner
2022-03-16 15:24 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b915aa7-838c-4acf-5f02-6c51b8be9869@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox