From: Fiona Ebner <f.ebner@proxmox.com>
To: Markus Ebner <info@ebner-markus.de>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH qemu-server v2 2/3] agent: file-read: Allow maintaining base64-encoding of content
Date: Thu, 26 Feb 2026 13:04:48 +0100 [thread overview]
Message-ID: <6ac7fe41-29f9-4dda-bb6a-46cbca836484@proxmox.com> (raw)
In-Reply-To: <20260225112851.124188-3-info@ebner-markus.de>
Am 25.02.26 um 1:06 PM schrieb Markus Ebner:
> The previous implementation always decoded the base64-encoded content
> received from the qemu-guest-agent file-read call. Since JSON strings
> must be comliant unicode text, binary data got escaped using unicode
> escape sequences, using the pattern: \u00XX - with XX being the hex
> value of the byte to encode. For certain binary files, this lead to a
> massively inflated payload size of the API response.
>
> Comparison on my test system:
> For a 4MiB test-file generated using
> dd if=/dev/urandom bs=4M count=1
>
> - Reading it with decode=1 transfers 8.61MiB and takes 5700ms on avg.
> - Reading it with decode=0 transfers 5.59MiB and takes 3300ms on avg.
>
> To be backwards compatible, the decode parameter defaults to 1.
>
> Signed-off-by: Markus Ebner <info@ebner-markus.de>
Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
next prev parent reply other threads:[~2026-02-26 12:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 11:28 [PATCH qemu-server v2 0/3] Extend qga file-read with chunked access for large files Markus Ebner
2026-02-25 11:28 ` [PATCH qemu-server v2 1/3] agent: file-read: Allow specifying max number of bytes to read Markus Ebner
2026-02-26 12:04 ` Fiona Ebner
2026-02-25 11:28 ` [PATCH qemu-server v2 2/3] agent: file-read: Allow maintaining base64-encoding of content Markus Ebner
2026-02-26 12:04 ` Fiona Ebner [this message]
2026-02-25 11:28 ` [PATCH qemu-server v2 3/3] agent: file-read: Allow specifying byte offset to start reading at Markus Ebner
2026-02-26 12:04 ` Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ac7fe41-29f9-4dda-bb6a-46cbca836484@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=info@ebner-markus.de \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox