From: Aaron Lauterer <a.lauterer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH manager v2] fix #5894: pvestatd: improve broadcast of node version-info
Date: Mon, 14 Jul 2025 10:25:18 +0200 [thread overview]
Message-ID: <6ac58f52-bfe8-4681-bf6c-fea2d429d8a2@proxmox.com> (raw)
In-Reply-To: <20250227143356.1089350-1-a.lauterer@proxmox.com>
sent a rebased v3:
https://lore.proxmox.com/pve-devel/20250714082358.56826-1-a.lauterer@proxmox.com/
On 2025-02-27 15:33, Aaron Lauterer wrote:
> Until now, the pvestatd did broadcast the pve-manager version only once
> after startup of the service. But there are some situations, where the
> local pmxcfs (pve-cluster) restarts and loses that information.
> Basically everytime we restart the pmxcfs without restarting pvestatd
> too.
>
> For example, on a cluster join, or if the pmxcfs has been restarted
> manually.
>
> By additionally checking if the local kv-store of the pmxcfs has any
> version info for the node, we can decide if another broadcast is
> necessary.
> Therefore after the next run of pvestatd, we should have the full
> version info available again.
>
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> changes since v2:
> * use scalar() around check if keys are present
> * mention bug this fixes
>
> PVE/Service/pvestatd.pm | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/PVE/Service/pvestatd.pm b/PVE/Service/pvestatd.pm
> index 7fa003fe..ff9a5c8b 100755
> --- a/PVE/Service/pvestatd.pm
> +++ b/PVE/Service/pvestatd.pm
> @@ -527,7 +527,10 @@ sub update_sdn_status {
>
> my $broadcast_version_info_done = 0;
> my sub broadcast_version_info : prototype() {
> - if (!$broadcast_version_info_done) {
> + if (
> + !$broadcast_version_info_done
> + || !scalar(keys PVE::Cluster::get_node_kv('version-info', $nodename)->%*)
> + ) {
> PVE::Cluster::broadcast_node_kv(
> 'version-info',
> encode_json(PVE::pvecfg::version_info()),
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-07-14 8:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-27 14:33 Aaron Lauterer
2025-07-14 8:25 ` Aaron Lauterer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ac58f52-bfe8-4681-bf6c-fea2d429d8a2@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox