From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager] fix #4627: ui: backup edit: don't deselect all vms on load
Date: Wed, 12 Apr 2023 13:28:40 +0200 [thread overview]
Message-ID: <6a021972-6bdd-4982-d046-d8068bf3f317@proxmox.com> (raw)
In-Reply-To: <20230331100308.1922021-1-d.csapak@proxmox.com>
Am 31/03/2023 um 12:03 schrieb Dominik Csapak:
> 'selectPoolMembers' will be called when the poolid field changes.
> (That can even happen when the mode is not even 'pool')
> Due to how the fields are set, there is a race condition that this
> will be called after the remaining fields were set up, including
> the vm list that might have entires selected.
>
> Since the first thing we do here is to deselect all, this wiped
> the vm selection sometimes.
>
> To fix it, check if we're actually in the correct mode before doing
> anything.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/manager6/dc/Backup.js | 6 ++++++
> 1 file changed, 6 insertions(+)
>
>
applied, thanks!
prev parent reply other threads:[~2023-04-12 11:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 10:03 [pve-devel] " Dominik Csapak
2023-04-12 11:28 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a021972-6bdd-4982-d046-d8068bf3f317@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox