From: Fiona Ebner <f.ebner@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Daniel Kral <d.kral@proxmox.com>,
pve-devel@lists.proxmox.com
Subject: Re: [PATCH container v2 3/4] setup: add no-op detect_architecture for unmanaged CTs
Date: Fri, 6 Feb 2026 16:04:07 +0100 [thread overview]
Message-ID: <69339b38-298a-4caa-9c85-030c43aaa938@proxmox.com> (raw)
In-Reply-To: <b0a7c747-f48c-43c7-89ca-73f9d7dc5da6@proxmox.com>
Am 06.02.26 um 3:28 PM schrieb Thomas Lamprecht:
> Am 06.02.26 um 14:08 schrieb Fiona Ebner:
>>> +sub detect_architecture {
>>> + my ($self) = @_;
>>> + return;
>> Thinking through it again, should we rather just die here instead of
>> returning undef? It seems to me that the contract for the method is
>> currently "either return the detected architecture or die". Then patch
>
> That description of the contract is not correct, for normal os types
> it fails if the arch could not be detected, for unmanaged this should
> not be the case, as we never can detect it there by design, and returning
> undef is more correct as of now.
Since there is no documentation, I took 'contract' to be "the current
behavior and expectation of the use sites". But changing this is fine by
me too.
>
>> 4/4 would not be needed. Your new implementation adds a "or return
>> undef" to the contract making it more complicated.
>
next prev parent reply other threads:[~2026-02-06 15:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-06 12:45 [PATCH-SERIES container v2 0/4] add missing no-op methods " Daniel Kral
2026-02-06 12:45 ` [PATCH container v2 1/4] setup: plugin: add missing check_systemd_nesting stub Daniel Kral
2026-02-06 12:45 ` [PATCH container v2 2/4] fix #7270: setup: add no-op check_systemd_nesting for unmanaged CTs Daniel Kral
2026-02-06 12:45 ` [PATCH container v2 3/4] setup: add no-op detect_architecture " Daniel Kral
2026-02-06 13:09 ` Fiona Ebner
2026-02-06 14:30 ` Thomas Lamprecht
2026-02-06 15:04 ` Fiona Ebner [this message]
2026-02-06 14:30 ` applied: " Thomas Lamprecht
2026-02-06 12:45 ` [PATCH container v2 4/4] setup: make the architecture fall back to amd64 for falsy values Daniel Kral
2026-02-06 14:30 ` applied: " Thomas Lamprecht
2026-02-06 13:18 ` partially-applied: [PATCH-SERIES container v2 0/4] add missing no-op methods for unmanaged CTs Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69339b38-298a-4caa-9c85-030c43aaa938@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=d.kral@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox