From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH http-server] fix regression in api/html (bootstrap) viewer
Date: Tue, 30 May 2023 14:43:59 +0200 [thread overview]
Message-ID: <68e1812f-e175-db03-fda2-86bb18587e20@proxmox.com> (raw)
In-Reply-To: <20230530115625.2966159-1-d.csapak@proxmox.com>
Am 30/05/2023 um 13:56 schrieb Dominik Csapak:
> recent versions of URI::Escape seem to handle the 'unsafe characters'
> parameter differently than before, enforcing what is documented:
>
> The set is specified as a string that can be used in a regular
> expression character class (between [ ]).
>
> so the leading/trailing [] were never supposed to be there.
Since liburi-perl 5.15 we could also use a qr// regex object [0], maybe that
would be a bit more explicit here; Debian Bookworm has already 5.17 available.
[0]: https://github.com/libwww-perl/URI/commit/a3f96169b002e1fa747713654edfa9f528d17cbb
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> src/PVE/APIServer/Formatter/Bootstrap.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
Anyhow, we don't have to touch this often and its for a dev/debug features, so
for now:
applied, with commit message amended with referencing the commit that broke
our usage and the possibility of regex objects, thanks!
prev parent reply other threads:[~2023-05-30 12:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 11:56 [pve-devel] " Dominik Csapak
2023-05-30 12:43 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68e1812f-e175-db03-fda2-86bb18587e20@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox