From: Filip Schauer <f.schauer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox v2 2/2] oci: tests: generate OCI test images on the fly
Date: Wed, 2 Sep 2026 11:07:14 +0200 [thread overview]
Message-ID: <68dc75cb-ec7a-41f3-98b2-51f3f9e51740@proxmox.com> (raw)
In-Reply-To: <20260720095030.64797-3-f.schauer@proxmox.com>
On 20/07/2026 11:52, Filip Schauer wrote:
> Get rid of the pre-built tar files and instead generate them on the fly.
> This makes the tests easier to understand and it is also easier to write
> new tests this way.
>
> This also fixes extraction failures when running tests as a non-root
> user. The old tar files used UID/GID 0 for all layer entries, whereas
> now the effective UID/GID of the test runner is used instead.
Append the following paragraph to the commit message:
This also fixes accidental OCI spec violations in
oci_test_replace_dir_with_file.tar and
oci_test_whiteout_current_directory.tar where the order of the "layers"
in the image manifest did not match the order of the "diff_ids" in the
image configuration.
---
It would be nice to get this applied, since I am currently working on a
series that depends on these patches.
prev parent reply other threads:[~2026-09-02 9:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 9:50 [PATCH proxmox v2 0/2] oci: tests: refactor to drop static test tarballs Filip Schauer
2026-07-20 9:50 ` [PATCH proxmox v2 1/2] oci: tests: return Result from tests to avoid unwrap calls Filip Schauer
2026-07-20 9:50 ` [PATCH proxmox v2 2/2] oci: tests: generate OCI test images on the fly Filip Schauer
2026-09-02 9:07 ` Filip Schauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68dc75cb-ec7a-41f3-98b2-51f3f9e51740@proxmox.com \
--to=f.schauer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox