public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Lukas Wagner <l.wagner@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH proxmox] notify: remove legacy filters and groups
Date: Tue, 3 Dec 2024 10:00:21 +0100	[thread overview]
Message-ID: <688625f9-631f-4f46-9a40-cc50392b27a5@proxmox.com> (raw)
In-Reply-To: <56841fc4-5486-4d5e-b254-6d65dd342ce9@proxmox.com>



On  2024-12-02 16:29, Thomas Lamprecht wrote:
> Am 02.12.24 um 14:32 schrieb Lukas Wagner:
>> It has been a full year now, so I'd argue it is safe to drop these
>> safety guards now. On the off chance that there are still systems out
>> there which still have these entries in their notifications.cfg,
>> a manual removal from the file will be needed after this commit.
> 
> It be safer to argue versions not time here, as users simply can not upgrade
> a system for over a year and then run into such things, if the boundary is a
> major version OTOH they cannot run into this by just upgrading, and we could
> add a safety check to the future pve8to9 upgrade checker script.

Yes, you are right about versions being the more important factor.

Since this is a just a bit of cleanup in proxmox-notify, I see no problem with postponing
this until PVE 9 and then adding it as a check to the pve8to9 script.
There really is no rush for this and this seems to be less work than adding a check
to d/postinst.

Thanks for your input!

> 
> But, it indeed seems a bit unlikely to trigger frequently in practice, so as
> middleground we could add a simple detection heuristic to d/postinst and if
> an old-style notification is detected print a big notice about how one can
> fix this manually or try to rename the config file to notifications.cfg.old
> or the like, as we basically can never have the legacy and new stuff mixed
> IIRC.

-- 
- Lukas



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      reply	other threads:[~2024-12-03  9:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-02 13:32 Lukas Wagner
2024-12-02 15:29 ` Thomas Lamprecht
2024-12-03  9:00   ` Lukas Wagner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=688625f9-631f-4f46-9a40-cc50392b27a5@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal