From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Aaron Lauterer <a.lauterer@proxmox.com>
Subject: Re: [pve-devel] [PATCH storage] rbd: fix #4060 show data-pool usage when configured
Date: Tue, 17 May 2022 16:01:15 +0200 [thread overview]
Message-ID: <687e8bfb-cee3-9a1e-f5fc-c68081456e75@proxmox.com> (raw)
In-Reply-To: <20220517125845.2701788-1-a.lauterer@proxmox.com>
On 5/17/22 14:58, Aaron Lauterer wrote:
> When a data-pool is configured, use it for status infos. The 'data-pool'
> config option is used to mark the erasure coded pool while the 'pool'
> will be the replicated pool holding meta data such as the omap.
>
> This means, the 'pool' will only use a small amount of space and people
> are interested how much they can store in the erasure coded pool anyway.
>
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> I decided to check for the IMO more likely case first and check against
> a configured data-pool. Afterwards check if we actually need to set the
> default pool name in case the pool property is omitted in the storage
> config.
>
> PVE/Storage/RBDPlugin.pm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/PVE/Storage/RBDPlugin.pm b/PVE/Storage/RBDPlugin.pm
> index fb48c3f..da28e8a 100644
> --- a/PVE/Storage/RBDPlugin.pm
> +++ b/PVE/Storage/RBDPlugin.pm
> @@ -630,7 +630,8 @@ sub status {
> my $rados = $librados_connect->($scfg, $storeid);
> my $df = $rados->mon_command({ prefix => 'df', format => 'json' });
>
> - my $pool = $scfg->{pool} ? $scfg->{pool} : 'rbd';
> + my $pool = $scfg->{'data-pool'} ? $scfg->{'data-pool'} : $scfg->{pool};
> + $pool = 'rbd' if !$pool;
>
> my ($d) = grep { $_->{name} eq $pool } @{$df->{pools}};
>
without looking more closely at the surrounding code and how we
set/get those properties, wouldn't it also possble to do:
my $pool = $scfg->{'data-pool'} // $scfg->{pool} // 'rbd';
?
next prev parent reply other threads:[~2022-05-17 14:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 12:58 Aaron Lauterer
2022-05-17 14:01 ` Dominik Csapak [this message]
2022-05-17 14:07 ` Aaron Lauterer
2022-05-18 6:19 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=687e8bfb-cee3-9a1e-f5fc-c68081456e75@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox