Re: [pve-devel] [PATCH v6 qemu-server 3/5] cli: disk reassign: add reassign_disk to qm command

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

On 02.04.21 12:19, Aaron Lauterer wrote:
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> v5 -> v6: nothing
> v4 -> v5: renamed `drive_key` to `drive_name`
> v3 ->v4: nothing
> v2 -> v3: renamed parameter `disk` to `drive_key`
> rfc -> v1 -> v2: nothing changed
>  PVE/CLI/qm.pm | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm
> index f8972bd..36ae8e7 100755
> --- a/PVE/CLI/qm.pm
> +++ b/PVE/CLI/qm.pm
> @@ -914,6 +914,8 @@ our $cmddef = {
>  
>      move_disk => [ "PVE::API2::Qemu", 'move_vm_disk', ['vmid', 'disk', 'storage'], { node => $nodename }, $upid_exit ],
>  
> +    reassign_disk => [ "PVE::API2::Qemu", 'reassign_vm_disk', ['vmid', 'target_vmid', 'drive_name'], { node => $nodename } ],

no new commands/params with underscore as separator please.

We can actually do s/move_disk/move-disk/ for above in a separate patch and
add an alias for the old one:

move_disk => { alias => 'move-disk' },

> +
>      unlink => [ "PVE::API2::Qemu", 'unlink', ['vmid'], { node => $nodename } ],
>  
>      config => [ "PVE::API2::Qemu", 'vm_config', ['vmid'],
>