[pve-devel] applied: [PATCH manager 1/3] ui: ldap: ad: support 'mode' paramter, replacing 'secure'

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 27/07/2023 um 10:57 schrieb Lukas Wagner:
> The backend has supported the 'mode' parameter for quite a while,
> however it has not yet been exposed in the GUI, contrary to PMG
> and PBS.
> 
> The benefit of 'mode' is that it supports LDAP, LDAPS and LDAP via
> STARTTLS, compared to just LDAP/LDAPS for the 'secure' parameter.
> 
> The modified AuthEdit{LDAP,AD} panel will now automatically migrate
> to the new paramter by hooking into onGetValues/onSetValues.
> 
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
>  www/manager6/dc/AuthEditAD.js   | 43 +++++++++++++++++++++++++++------
>  www/manager6/dc/AuthEditLDAP.js | 42 ++++++++++++++++++++++++++------
>  2 files changed, 71 insertions(+), 14 deletions(-)
> 
>

applied series, thanks!

FWIW, I prefer having trivial stuff (typos, uncontroversial renames like
SSL -> TLS) upfront, as then one can apply them immediately even if there
would be something left to adapt on the actual "meat" of the series.
Anyway, it didn't really matter here, so just mentioning to avoid that
others copy this for when it does matter.