From: "DERUMIER, Alexandre" <Alexandre.DERUMIER@groupe-cyllene.com>
To: "pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH firewall 0/1] fix #3677 ipset_get_chains fixed to work with new ipset output
Date: Thu, 21 Oct 2021 07:04:29 +0000 [thread overview]
Message-ID: <67ff1d0bd07be7293c4e64934ae876704a5445cb.camel@groupe-cyllene.com> (raw)
In-Reply-To: <20211018202132.4072-1-mgit@fragmentedpackets.net>
Hi,
Thanks for the patch ! I didn't notice it, but I have indeed this bug.
I have tested it , it's working fine for me.
Before the patch :
# pve-firewall status
Status: enabled/running (pending changes)
After the patch:
pve-firewall status
Status: enabled/running
Le lundi 18 octobre 2021 à 21:21 +0100, Mark Yardley a écrit :
> As I reported in 3677, there has been a change to the output of ipset
> since the
> update to bullseye and the introduction of ipset 7.
>
> There are now additional items on each line which is causing the
> firewall to
> stay in pending changes as the comparison to the applied rules never
> matches
> despite being valid.
>
> This patch ignores the additonal values and provides a valid line that
> can
> be matched from the ipset output.
>
> Mark Yardley (1):
> fix #3677 ipset_get_chains fixed to work with new ipset output
>
> src/PVE/Firewall.pm | 4 ++++
> 1 file changed, 4 insertions(+)
>
next prev parent reply other threads:[~2021-10-21 7:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 20:21 Mark Yardley
2021-10-18 20:21 ` [pve-devel] [PATCH firewall 1/1] " Mark Yardley
2021-10-27 11:30 ` Thomas Lamprecht
2021-10-27 13:48 ` Mark Yardley
2021-10-29 18:09 ` [pve-devel] applied + follow up: [PATCH] fix #3677: follow up: actually handle bucket size and ignore initval Thomas Lamprecht
2021-10-21 7:04 ` DERUMIER, Alexandre [this message]
2021-10-25 14:43 ` [pve-devel] [PATCH firewall 0/1] fix #3677 ipset_get_chains fixed to work with new ipset output DERUMIER, Alexandre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67ff1d0bd07be7293c4e64934ae876704a5445cb.camel@groupe-cyllene.com \
--to=alexandre.derumier@groupe-cyllene.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox