Re: [PATCH manager/pmg-api/proxmox{,-backup,-perl-rs,-offline-mirror} 0/8] adapt subscription handling to alternative server IDs

[Samuel Rufinatscha <s.rufinatscha@proxmox.com>]

Please find below a summary of the tests i performed:

PVE:
- existing SshMd5 subscription stays "active" after the patch
- update using --force on a pre-existing subscription works
- delete + set without reissue is rejected with "Invalid Server ID"
   as expected, since the patched client sends MachineId
- After reissue, delete + set binds the subscription to the new
   MachineId
- Regenerating the SSH host keys on a MachineId-bound subscription
   does not change its status, no reissue needed

PMG: tested the same scenarios as PVE

POM:
- existing SshMd5 mirror subscription stays "active" after the
   patch
- key refresh on a pre-existing subscription works
- key remove + key add-mirror-key without reissue is rejected with
   "Invalid Server ID" as expected

For PDM I tested if the subscription of the patched
remote shows up as active in the PDM system report.
Tested using a Community Subscription.

I didn't run into any errors and didn't notice anything that looks off.

Tested-by: Samuel Rufinatscha <s.rufinatscha@proxmox.com>

On 5/7/26 1:59 PM, Fabian Grünbichler wrote:
> instead of only supporting one variant of server IDs, get a list of possible
> candidates via the proxmox-subscription crate. if a subscription is already
> configured, the matching server ID will be reused to avoid reissuing.
> 
> v1:
> - drop proxmox-systemd part, already applied
> - add PMG changes
> - add PDM changes
> - add POM changes
> - rebase
> 
> order of bumping:
> - proxmox-subscription (breaks PBS/PDM/POM)
> 
> - pve-rs/pmg-rs (needs proxmox-subscription)
> - pve-manager (needs pve-rs)
> - pmg-api (needs pmg-rs)
> 
> - pbs (needs proxmox-subscription)
> 
> - pdm (needs proxmox-subscription)
> 
> - pom (needs proxmox-subscription)
> 
> tested PBS/PVE, additional testing of PMG/POM/PDM would be highly
> appreciated.
> 
> sending to pve-devel, since it's our main list - this of course is a
> cross-product patch series ;)
> 
> 
> proxmox:
> 
> Fabian Grünbichler (1):
>    proxmox-subscription: add new machine-id based serverid
> 
>   proxmox-subscription/Cargo.toml               |   3 +-
>   proxmox-subscription/src/lib.rs               |   2 +-
>   proxmox-subscription/src/subscription_info.rs | 105 ++++++++++++++++--
>   3 files changed, 96 insertions(+), 14 deletions(-)
> 
> 
> proxmox-backup:
> 
> Fabian Grünbichler (1):
>    subscription: adapt to multiple server ID variants
> 
>   src/api2/node/subscription.rs | 38 ++++++++++++++++++++++++++---------
>   1 file changed, 28 insertions(+), 10 deletions(-)
> 
> 
> proxmox-perl-rs:
> 
> Fabian Grünbichler (1):
>    common: subscription: expose server ID candidates
> 
>   common/src/bindings/subscription.rs | 11 +++++++++++
>   1 file changed, 11 insertions(+)
> 
> 
> pve-manager:
> 
> Fabian Grünbichler (2):
>    subscription: adapt to multiple server ID variants
>    api2tools: remove unused get_hwaddress
> 
>   PVE/API2/Subscription.pm | 26 ++++++++++++++++++++------
>   PVE/API2Tools.pm         | 23 -----------------------
>   2 files changed, 20 insertions(+), 29 deletions(-)
> 
> 
> pmg-api:
> 
> Fabian Grünbichler (2):
>    subscription: adapt to multiple server ID variants
>    utils: drop now unused get_hwaddress
> 
>   src/PMG/API2/Subscription.pm | 27 +++++++++++++++++++++------
>   src/PMG/Utils.pm             | 23 -----------------------
>   2 files changed, 21 insertions(+), 29 deletions(-)
> 
> 
> proxmox-offline-mirror:
> 
> Fabian Grünbichler (1):
>    subscription handling: adapt to multiple server ID candidates
> 
>   src/bin/proxmox-offline-mirror-helper.rs      | 36 +++++++++++++++----
>   src/bin/proxmox-offline-mirror.rs             |  6 +++-
>   .../subscription.rs                           |  5 ++-
>   3 files changed, 39 insertions(+), 8 deletions(-)
> 
> 
> Summary over all repositories:
>    12 files changed, 215 insertions(+), 90 deletions(-)
>