From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: [pve-devel] applied: [PATCH proxmox-kernel-helper] grub-wrapper: don't fail on reinit/refresh error
Date: Tue, 21 Nov 2023 09:21:32 +0100 [thread overview]
Message-ID: <67d46d2c-c227-4b77-a775-1a1be85a4172@proxmox.com> (raw)
In-Reply-To: <20231121075305.3531240-1-f.gruenbichler@proxmox.com>
Am 21/11/2023 um 08:53 schrieb Fabian Grünbichler:
> these can happen for example if the system
> - is set up to boot using systemd-boot
> - but grub updates trigger a call to "grub-install"
> - and systemd-boot is not installed
>
> in this case, "proxmox-boot-tool reinit" will fail because of the lack of
> "systemd-boot", and the upgrade triggering the grub-install call would error
> out.
>
> all the error messages/warnings are still printed and hopefully noticed.
>
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> src/bin/grub-install-wrapper | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2023-11-21 8:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 7:53 [pve-devel] " Fabian Grünbichler
2023-11-21 8:21 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67d46d2c-c227-4b77-a775-1a1be85a4172@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox