From: Aaron Lauterer <a.lauterer@proxmox.com>
To: Oguz Bektas <o.bektas@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH v2 manager] ui: vm network: allow to override MTU for virtio devices
Date: Thu, 10 Feb 2022 15:14:43 +0100 [thread overview]
Message-ID: <679d1c44-4559-8c7e-54a6-4134b7a2036b@proxmox.com> (raw)
In-Reply-To: <YgUcX9X36H1LUxCu@gaia>
On 2/10/22 15:08, Oguz Bektas wrote:
> thanks for the test and review!
>
> instead of a validator function i guess we could just set minValue and
> maxValue as well? (since allowBlank is set to true)
>
> seemed to work fine in my short testing just now :)
>
> diff --git a/www/manager6/qemu/NetworkEdit.js b/www/manager6/qemu/NetworkEdit.js
> index 1e34ad1c..a3fa5724 100644
> --- a/www/manager6/qemu/NetworkEdit.js
> +++ b/www/manager6/qemu/NetworkEdit.js
> @@ -184,6 +184,8 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
> bind: {
> disabled: '{!isVirtio}',
> },
> + minValue: 1,
> + maxValue: 65520,
> allowBlank: true,
> },
> ];
Duh of course...
That does what we want and is much nicer :)
prev parent reply other threads:[~2022-02-10 14:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 11:28 Oguz Bektas
2022-02-10 13:53 ` Aaron Lauterer
2022-02-10 13:55 ` Aaron Lauterer
2022-02-10 14:08 ` Oguz Bektas
2022-02-10 14:14 ` Aaron Lauterer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=679d1c44-4559-8c7e-54a6-4134b7a2036b@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=o.bektas@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox