public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH-SERIES qemu-server/manager] restore PVE 7 default for cloudinit package upgrades
Date: Wed, 21 Jun 2023 12:47:05 +0200	[thread overview]
Message-ID: <6764ed08-4374-1125-1eac-903afade1cd8@proxmox.com> (raw)
In-Reply-To: <20230621100433.36525-1-f.ebner@proxmox.com>

Am 21/06/2023 um 12:04 schrieb Fiona Ebner:
> Commit efa3355d ("fix #3428: cloudinit: add parameter for upgrade on
> boot") changed the default, but this is a breaking change. The bug
> report was only about making the option configurable.
> 
> The commit doesn't give an explicit reason for why, and arguably,
> doing the upgrade is not an issue for most users. It also leads to a
> different cloud-init instance ID, because of the different setting,
> which in turn leads to ssh host key regeneration within the VM.
> 
> Dependency bump manager -> qemu-server doesn't hurt to keep things
> aligned (at least in one direction).
> 
> Thanks to Friedrich for catching the issue!
> 
> 
> qemu-server:
> 
> Fiona Ebner (2):
>   schema: cloudinit: document default for ciupgrade
>   cloudinit: restore previous default for package upgrades
> 
>  PVE/QemuServer.pm           | 3 ++-
>  PVE/QemuServer/Cloudinit.pm | 2 +-
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> 
> manager:
> 
> Fiona Ebner (1):
>   ui: cloudinit: align default value for package upgrades with backend
>     again
> 
>  www/manager6/qemu/CloudInit.js | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 


applied series, thanks!




      parent reply	other threads:[~2023-06-21 10:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-21 10:04 [pve-devel] " Fiona Ebner
2023-06-21 10:04 ` [pve-devel] [PATCH qemu-server 1/2] schema: cloudinit: document default for ciupgrade Fiona Ebner
2023-06-21 10:04 ` [pve-devel] [PATCH qemu-server 2/2] cloudinit: restore previous default for package upgrades Fiona Ebner
2023-06-21 10:04 ` [pve-devel] [PATCH manager 1/1] ui: cloudinit: align default value for package upgrades with backend again Fiona Ebner
2023-06-21 10:47 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6764ed08-4374-1125-1eac-903afade1cd8@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal