From: Christoph Heiss <c.heiss@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH installer 0/3] add check/rename for already-existing ZFS rpool
Date: Thu, 11 Jul 2024 14:00:25 +0200 [thread overview]
Message-ID: <66ybsndl3vxnhf6qf5ipp66o2sh6bpusrkbdierjagpem3lhsb@ymvos363toni> (raw)
In-Reply-To: <20240516102837.422278-1-c.heiss@proxmox.com>
v3 (already) out: https://lists.proxmox.com/pipermail/pve-devel/2024-July/064635.html
On Thu, May 16, 2024 at 12:28:32PM GMT, Christoph Heiss wrote:
> Pretty straight forward overall, implements a check for an exising
> `rpool` on the system and ask the user whether they would like to rename
> it, much in the same way as it works for VGs already.
>
> Without this, the installer would silently create a second (and thus
> conflicting) `rpool` and cause a boot failure after the installation,
> since it does not know which pool to import exactly.
>
> Christoph Heiss (3):
> proxmox: add zfs module for retrieving importable zpool info
> low-level: install: split out random disk uid generation
> low-level: install: check for already-existing `rpool` on install
>
> Proxmox/Install.pm | 47 ++++++++++++++++++++++++++++++++-----
> Proxmox/Makefile | 1 +
> Proxmox/Sys/ZFS.pm | 43 ++++++++++++++++++++++++++++++++++
> test/Makefile | 6 +++++
> test/zfs-get-pool-list.pl | 49 +++++++++++++++++++++++++++++++++++++++
> 5 files changed, 140 insertions(+), 6 deletions(-)
> create mode 100644 Proxmox/Sys/ZFS.pm
> create mode 100755 test/zfs-get-pool-list.pl
>
> --
> 2.44.0
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-07-11 12:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-16 10:28 Christoph Heiss
2024-05-16 10:28 ` [pve-devel] [PATCH installer 1/3] low-level: add zfs module for retrieving importable zpool info Christoph Heiss
2024-07-08 14:24 ` Aaron Lauterer
2024-07-08 15:13 ` Christoph Heiss
2024-05-16 10:28 ` [pve-devel] [PATCH installer 2/3] low-level: install: split out random disk uid generation Christoph Heiss
2024-05-16 10:28 ` [pve-devel] [PATCH installer 3/3] low-level: install: check for already-existing `rpool` on install Christoph Heiss
2024-07-08 14:16 ` Aaron Lauterer
2024-07-08 15:16 ` Christoph Heiss
2024-07-08 11:27 ` [pve-devel] [PATCH installer 0/3] add check/rename for already-existing ZFS rpool Christoph Heiss
2024-07-11 12:00 ` Christoph Heiss [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66ybsndl3vxnhf6qf5ipp66o2sh6bpusrkbdierjagpem3lhsb@ymvos363toni \
--to=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox