public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Andreas Rogge <andreas.rogge@bareos.com>
To: pve-devel@lists.proxmox.com
Cc: Philipp Storz <philipp.storz@bareos.com>
Subject: Re: [pve-devel] [PATCH storage v4 09/27] plugin: introduce new_backup_provider() method
Date: Tue, 1 Apr 2025 18:02:34 +0200	[thread overview]
Message-ID: <66969dc5-7587-46fc-8b36-8ecf0d5d744a@bareos.com> (raw)
In-Reply-To: <20241114150754.374376-10-f.ebner@proxmox.com>

Hi everyone,

sorry for digging up that ancient mail, but I feel that's the best 
starting point for me.
Bareos investigates how to better integrate with Proxmox VE, so users 
can take backups of virtual machines and restore them using Bareos.

Am 14.11.24 um 16:07 schrieb Fiona Ebner:
> The new_backup_provider() method can be used by storage plugins for
> external backup providers. If the method returns a provider, Proxmox
> VE will use callbacks to that provider for backups and restore instead
> of using its usual backup/restore mechanisms.
So we as a backup provider need to provide plugin code that will run as 
part of PVE. If I understand correctly this must be implemented as a 
Perl module. Also, PVE wants to trigger the backup itself.

This introduces a few hurdles for us:
First of all, we don't usually program in Perl, so that's going to be a 
problem for us. We can probably implement something, but we probably 
don't have any developer that can write Perl code that meets any kind of 
professional standard.

To do its job[1], Bareos must be able to schedule backup and restore 
jobs all by itself. If I understood correctly, backups utilizing one of 
the plugins can be run by calling `vzdump`, so that this is at least 
possible.

However, what we've seen other vendors do is that they provide an API 
where you just tell the system what VM you want to back up and then you 
are provided with access to metadata (i.e. VM configuration, disk 
layouts, nvram content, etc) and disk contents.
For restore it is mostly the same: you provide the metadata, get a set 
of raw disks that you can write your data to and finally you just tell 
the system that the VM restore is done.


> The backup provider API is split into two parts, both of which again
> need different implementations for VM and LXC guests:
[...]

> 1.1 Backup Mechanisms
> 
[...]
> VM mechanism 'block-device':
> The snapshot access is exposed as a block device. If used, a bitmap is
> passed along.
> 
> VM mechanism 'nbd':
> The snapshot access and, if used, bitmap are exported via NBD.

That looks reasonable.

> 2. Restore API
> 
> 2.1. Restore Mechanisms
> 
> VM mechanism 'qemu-img':
> 
> The backup provider gives a path to the disk image that will be
> restored. The path needs to be something 'qemu-img' can deal with,
> e.g. can also be an NBD URI or similar.
Um... that has nothing to do with what you provided when we take the 
backup. Is there a reason PVE cannot provide a writeable block device to 
restore to?
For Bareos this requirement would imply that we need an unpleasantly 
large staging area on the PVE node to facilitate a restore: As we can 
only stream the data we'd have to create a temporary disk image that PVE 
can then read. This sounds pretty inefficient - especially when 
comparing with qmrestore's ability to just read read from stdin.

Best Regards,
Andreas


[1] As a backup software it is Bareos' job to make sure the production 
system is as strictly separated from the backup data as possible. While 
we understand how nice tight integration with PVE would be, we see this 
primarily as unnecessary attack surface.
For a nicely integrated solution that can bring back last week's VM 
snapshot with a few clicks, there's Proxmox Backup Server, which works 
great.




-- 
Andreas Rogge                             andreas.rogge@bareos.com
   Bareos GmbH & Co. KG                      Phone: +49 221-630693-86
   http://www.bareos.com

   Sitz der Gesellschaft: Köln | Amtsgericht Köln: HRA 29646
   Komplementär: Bareos Verwaltungs-GmbH
   Geschäftsführer: Stephan Dühr, Jörg Steffens, Philipp Storz


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

  reply	other threads:[~2025-04-01 16:03 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-14 15:07 [pve-devel] [PATCH-SERIES qemu/common/storage/qemu-server/container/manager v4 00/27] backup provider API Fiona Ebner
2024-11-14 15:07 ` [pve-devel] [PATCH qemu v4 01/27] PVE backup: add target ID in backup state Fiona Ebner
2024-11-14 15:07 ` [pve-devel] [PATCH qemu v4 02/27] PVE backup: get device info: allow caller to specify filter for which devices use fleecing Fiona Ebner
2024-11-14 15:07 ` [pve-devel] [PATCH qemu v4 03/27] PVE backup: implement backup access setup and teardown API for external providers Fiona Ebner
2024-11-14 15:07 ` [pve-devel] [PATCH qemu v4 04/27] PVE backup: implement bitmap support for external backup access Fiona Ebner
2024-11-14 15:07 ` [pve-devel] [PATCH common v4 05/27] test: lock file: get rid of END block that made test always pass Fiona Ebner
2024-11-14 19:46   ` [pve-devel] applied: " Thomas Lamprecht
2024-11-14 15:07 ` [pve-devel] [PATCH common v4 06/27] tools: run fork: allow running code in parent after fork Fiona Ebner
2024-11-14 19:46   ` [pve-devel] applied: " Thomas Lamprecht
2024-11-14 15:07 ` [pve-devel] [PATCH common v4 07/27] test: have lock file test use run_fork() helper Fiona Ebner
2024-11-14 19:46   ` [pve-devel] applied: " Thomas Lamprecht
2024-11-14 15:07 ` [pve-devel] [PATCH storage v4 08/27] add storage_has_feature() helper function Fiona Ebner
2024-11-14 15:07 ` [pve-devel] [PATCH storage v4 09/27] plugin: introduce new_backup_provider() method Fiona Ebner
2025-04-01 16:02   ` Andreas Rogge [this message]
2025-04-01 18:21     ` Thomas Lamprecht
2025-04-02  8:30       ` Wolfgang Bumiller
2025-04-02 16:16         ` Andreas Rogge
2025-04-03  7:24           ` Wolfgang Bumiller
2025-04-03 16:08             ` Andreas Rogge
2025-04-04  7:15               ` Fabian Grünbichler
2025-04-02  8:33       ` Fiona Ebner
2025-04-03  8:06         ` Andreas Rogge
2025-04-02 16:01       ` Andreas Rogge
2024-11-14 15:07 ` [pve-devel] [PATCH storage v4 10/27] extract backup config: delegate to backup provider for storages that support it Fiona Ebner
2024-11-14 15:07 ` [pve-devel] [POC storage v4 11/27] add backup provider example Fiona Ebner
2024-11-14 15:07 ` [pve-devel] [POC storage v4 12/27] WIP Borg plugin Fiona Ebner
2024-11-14 15:07 ` [pve-devel] [PATCH qemu-server v4 13/27] backup: keep track of block-node size for fleecing Fiona Ebner
2024-11-14 15:07 ` [pve-devel] [PATCH qemu-server v4 14/27] module config: load nbd module at boot Fiona Ebner
2024-11-14 15:07 ` [pve-devel] [PATCH qemu-server v4 15/27] backup: allow adding fleecing images also for EFI and TPM Fiona Ebner
2024-11-14 15:07 ` [pve-devel] [PATCH qemu-server v4 16/27] backup: implement backup for external providers Fiona Ebner
2024-11-14 15:07 ` [pve-devel] [PATCH qemu-server v4 17/27] backup: implement restore " Fiona Ebner
2024-11-14 15:07 ` [pve-devel] [PATCH qemu-server v4 18/27] backup restore: external: hardening check for untrusted source image Fiona Ebner
2024-11-14 15:07 ` [pve-devel] [PATCH container v4 19/27] add LXC::Namespaces module Fiona Ebner
2024-11-14 15:07 ` [pve-devel] [PATCH container v4 20/27] backup: implement backup for external providers Fiona Ebner
2024-11-14 15:07 ` [pve-devel] [PATCH container v4 21/27] backup: implement restore " Fiona Ebner
2024-11-14 15:07 ` [pve-devel] [PATCH container v4 22/27] external restore: don't use 'one-file-system' tar flag when restoring from a directory Fiona Ebner
2024-11-14 15:07 ` [pve-devel] [PATCH container v4 23/27] create: factor out compression option helper Fiona Ebner
2024-11-14 15:07 ` [pve-devel] [PATCH container v4 24/27] restore tar archive: check potentially untrusted archive Fiona Ebner
2024-11-14 15:07 ` [pve-devel] [PATCH container v4 25/27] api: add early check against restoring privileged container from external source Fiona Ebner
2024-11-14 15:07 ` [pve-devel] [PATCH manager v4 26/27] ui: backup: also check for backup subtype to classify archive Fiona Ebner
2024-11-14 15:07 ` [pve-devel] [PATCH manager v4 27/27] backup: implement backup for external providers Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=66969dc5-7587-46fc-8b36-8ecf0d5d744a@bareos.com \
    --to=andreas.rogge@bareos.com \
    --cc=philipp.storz@bareos.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal