From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager] api: ceph: mon create: remove superfluous verification call
Date: Wed, 12 Apr 2023 13:27:29 +0200 [thread overview]
Message-ID: <66910cbc-d148-94d8-ee04-2b47dcd0fd8e@proxmox.com> (raw)
In-Reply-To: <20230403093516.28385-1-f.ebner@proxmox.com>
Am 03/04/2023 um 11:35 schrieb Fiona Ebner:
> The pve_verify_cidr{,v4,v6} functions were originally intended for
> the /etc/network/interfaces API endpoints and thus are a bit
> restrictive. For example, as reported in the community forum[0],
> pve_verify_cidr() does not consider '0::/0' and '0::/1' to be valid.
>
> The error message in this scenario being
>> value does not look like a valid CIDR network
> is also confusing, as the first thought of users will be that it comes
> from the passed-in monitor address.
>
> The public networks are not written here and read from the Ceph config
> and via a RADOS mon command, so no need to try and verify them. If
> something really would go wrong during parsing, the
> get_local_ip_from_cidr() call would complain afterwards.
>
> [0]: https://forum.proxmox.com/threads/125226/
>
> Suggested-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> PVE/API2/Ceph/MON.pm | 4 ----
> 1 file changed, 4 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2023-04-12 11:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 9:35 [pve-devel] " Fiona Ebner
2023-04-12 11:27 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66910cbc-d148-94d8-ee04-2b47dcd0fd8e@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox