Re: [pve-devel] [PATCH qemu-server 1/1] api: migration preconditions: add node affinity as blocking cause

[Fiona Ebner <f.ebner@proxmox.com>]

Am 15.12.25 um 4:54 PM schrieb Daniel Kral:
> Signed-off-by: Daniel Kral <d.kral@proxmox.com>
> ---
> Needs a version bump for pve-ha-manager.
> 

Such a bump is only required in the sense that the enum variant cannot
actually happen before new ha-manager is installed. The patch here could
be applied without such a bump, upgraded and nothing would break.

But technically, it's a breaking change in the other direction. New HA
manager might cause old qemu-server to return something that was not
declared in the return schema. I guess it won't be a huge issue in
practice though. API clients already need to be prepared for new
variants being returned and the issue would only manifest if the API
client checks the correctness of the result against the installed, old
qemu-server API schema.

>  src/PVE/API2/Qemu.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm
> index 190878de..5c4f6eb3 100644
> --- a/src/PVE/API2/Qemu.pm
> +++ b/src/PVE/API2/Qemu.pm
> @@ -5196,7 +5196,7 @@ __PACKAGE__->register_method({
>                                      type => 'string',
>                                      description => "The reason why the HA"
>                                          . " resource is blocking the migration.",
> -                                    enum => ['resource-affinity'],
> +                                    enum => ['node-affinity', 'resource-affinity'],
>                                  },
>                              },
>                          },



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel