Re: [pve-devel] [PATCH proxmox_dart_api_client/pve_flutter_frontend v2 0/3] fix: ui: guest missing in resources tab when status is `paused`

["Michael Köppl" <m.koeppl@proxmox.com>]

Thanks for tackling this! Definitely improves the UX. I tested this in
my Android emulator. Paused guests were displayed with the correct
status instead of "Unknown" and I was able to filter for the "Paused"
status. Did not notice anything off. Well done!

I left some minor comments on the individual patches. With those
addressed, consider this:

Reviewed-by: Michael Köppl <m.koeppl@proxmox.com>
Tested-by: Michael Köppl <m.koeppl@proxmox.com>

On 6/2/25 15:37, Shan Shaji wrote:
> This patch series includes the fix for guest missing when the status 
> is `paused`. Additionaly the series also includes the changes from 
> another patch which can be found here: 
> 
> https://lore.proxmox.com/pve-devel/20250522130825.79862-1-s.shaji@proxmox.com/
> 
> pve_flutter_frontend:
> 
> Shan Shaji (2):
>   refactor: move and split the `_MobileResourceFilterSheet` widget
>   fix: ui: guests missing in resources tab when status is `paused`
> 
>  lib/pages/main_layout_slim.dart               | 175 +--------------
>  .../pve_mobile_resource_filter_sheet.dart     | 202 ++++++++++++++++++
>  2 files changed, 204 insertions(+), 173 deletions(-)
>  create mode 100644 lib/widgets/pve_mobile_resource_filter_sheet.dart
> 
> 
> proxmox_dart_api_client:
> 
> Shan Shaji (1):
>   fix: ui: add missing `paused` status check
> 
>  lib/src/models/pve_cluster_resources_model.dart | 2 ++
>  1 file changed, 2 insertions(+)
> 
> 
> Summary over all repositories:
>   3 files changed, 206 insertions(+), 173 deletions(-)
> 



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel