From: Aaron Lauterer <a.lauterer@proxmox.com>
To: Severen Redwood <severen.redwood@sitehost.co.nz>,
pve-devel@lists.proxmox.com
Cc: Thomas Lamprecht <t.lamprecht@proxmox.com>
Subject: Re: [pve-devel] [PATCH SERIES v3] Add ability to prevent suggesting previously used VM/CT IDs
Date: Tue, 5 Nov 2024 17:01:07 +0100 [thread overview]
Message-ID: <663d67da-37f3-4c27-8f90-8fe96f6c75e8@proxmox.com> (raw)
In-Reply-To: <D5DVFH6OZLBN.2KLGTH53ZHGNJ@sitehost.co.nz>
gave this series another spin in my test cluster and so far it seems to
work as described.
I did a very quick test if we see some noticeable "lag" when destroying
a guest by filling the `used_vmids.list` with IDs from 100..30000 and a
stepsize of 2, so close to 15k lines. But I didn't notice that it would
take longer.
A few small style nits are addressed, in the specific patches. But
nothing severe that would justify a v4 right away.
Consider this series:
Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>
Reviewed-By: Aaron Lauterer <a.lauterer@proxmox.com>
On 2024-11-05 02:58, Severen Redwood wrote:
> Hi everyone,
>
> This is a small update to my previous patch series [1, 2]
> adding optional support for preventing PVE from suggesting
> previously used VM/CT IDs.
>
> In particular, missing use statements have been added to the
> patches for marking VM/CT IDs as used, as noticed by Aaron
> [3]. Everything else remains the same as in v2.
>
> Also note when building this patch series that the pve-cluster
> patches must be applied and built first to prevent the build
> of pve-manager from failing.
>
> If anyone has any other feedback, please let me know.
>
> Thanks,
> Severen
>
> [1]: https://lore.proxmox.com/pve-devel/mailman.177.1728018639.332.pve-devel@lists.proxmox.com/
> [2]: https://lore.proxmox.com/pve-devel/mailman.624.1730255368.332.pve-devel@lists.proxmox.com/T/#t
> [3]: https://lore.proxmox.com/pve-devel/mailman.624.1730255368.332.pve-devel@lists.proxmox.com/T/#m7313a65f5b26f29ff0a2b4005069a7306311ccf6
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next parent reply other threads:[~2024-11-05 16:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <D5DVFH6OZLBN.2KLGTH53ZHGNJ@sitehost.co.nz>
2024-11-05 16:01 ` Aaron Lauterer [this message]
2024-11-08 0:44 ` Severen Redwood via pve-devel
2024-11-05 1:58 Severen Redwood via pve-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=663d67da-37f3-4c27-8f90-8fe96f6c75e8@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=severen.redwood@sitehost.co.nz \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox