* [pve-devel] [PATCH-SERIES] add none audio backend
@ 2021-01-07 17:02 Gilles Pietri
2021-01-07 17:02 ` [pve-devel] [PATCH qemu-server] audio: add the " Gilles Pietri
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Gilles Pietri @ 2021-01-07 17:02 UTC (permalink / raw)
To: pve-devel
Add the 'none' audio backend as an option for qemu-server: it behaves
the same as the spice one (id=,driver=), and simply discards audio.
Add the option in the Web UI for audio configuration.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [pve-devel] [PATCH qemu-server] audio: add the none audio backend
2021-01-07 17:02 [pve-devel] [PATCH-SERIES] add none audio backend Gilles Pietri
@ 2021-01-07 17:02 ` Gilles Pietri
2021-01-07 17:02 ` [pve-devel] [PATCH pve-manager] ui: qemu: add the none audio driver as an option Gilles Pietri
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Gilles Pietri @ 2021-01-07 17:02 UTC (permalink / raw)
To: pve-devel
Signed-off-by: Gilles Pietri <contact+dev@gilouweb.com>
---
PVE/QemuServer.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index bca5669..54278e5 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -211,7 +211,7 @@ my $audio_fmt = {
},
driver => {
type => 'string',
- enum => ['spice'],
+ enum => ['spice', 'none'],
default => 'spice',
optional => 1,
description => "Driver backend for the audio device."
--
2.30.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* [pve-devel] [PATCH pve-manager] ui: qemu: add the none audio driver as an option
2021-01-07 17:02 [pve-devel] [PATCH-SERIES] add none audio backend Gilles Pietri
2021-01-07 17:02 ` [pve-devel] [PATCH qemu-server] audio: add the " Gilles Pietri
@ 2021-01-07 17:02 ` Gilles Pietri
2021-01-08 12:29 ` [pve-devel] [PATCH-SERIES] add none audio backend Aaron Lauterer
2021-01-12 12:10 ` [pve-devel] applied-series: " Thomas Lamprecht
3 siblings, 0 replies; 5+ messages in thread
From: Gilles Pietri @ 2021-01-07 17:02 UTC (permalink / raw)
To: pve-devel
Signed-off-by: Gilles Pietri <contact+dev@gilouweb.com>
---
www/manager6/qemu/AudioEdit.js | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/www/manager6/qemu/AudioEdit.js b/www/manager6/qemu/AudioEdit.js
index 804e5a7a..4d039adf 100644
--- a/www/manager6/qemu/AudioEdit.js
+++ b/www/manager6/qemu/AudioEdit.js
@@ -29,10 +29,14 @@ Ext.define('PVE.qemu.AudioInputPanel', {
]
}, {
name: 'driver',
- xtype: 'displayfield',
+ xtype: 'proxmoxKVComboBox',
value: 'spice',
submitValue: true,
fieldLabel: gettext('Backend Driver'),
+ comboItems: [
+ ['spice', 'spice'],
+ ['none', 'none'],
+ ]
}]
});
--
2.30.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [pve-devel] [PATCH-SERIES] add none audio backend
2021-01-07 17:02 [pve-devel] [PATCH-SERIES] add none audio backend Gilles Pietri
2021-01-07 17:02 ` [pve-devel] [PATCH qemu-server] audio: add the " Gilles Pietri
2021-01-07 17:02 ` [pve-devel] [PATCH pve-manager] ui: qemu: add the none audio driver as an option Gilles Pietri
@ 2021-01-08 12:29 ` Aaron Lauterer
2021-01-12 12:10 ` [pve-devel] applied-series: " Thomas Lamprecht
3 siblings, 0 replies; 5+ messages in thread
From: Aaron Lauterer @ 2021-01-08 12:29 UTC (permalink / raw)
To: Proxmox VE development discussion, Gilles Pietri
The series looks good to me.
One thing we need to do is to adapt the documentation because right now it specifically mentions that the audio device only works in combination with Spice.
Reviewed-By: Aaron Lauterer <a.lauterer@proxmox.com>
Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>
On 1/7/21 6:02 PM, Gilles Pietri wrote:
> Add the 'none' audio backend as an option for qemu-server: it behaves
> the same as the spice one (id=,driver=), and simply discards audio.
> Add the option in the Web UI for audio configuration.
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [pve-devel] applied-series: [PATCH-SERIES] add none audio backend
2021-01-07 17:02 [pve-devel] [PATCH-SERIES] add none audio backend Gilles Pietri
` (2 preceding siblings ...)
2021-01-08 12:29 ` [pve-devel] [PATCH-SERIES] add none audio backend Aaron Lauterer
@ 2021-01-12 12:10 ` Thomas Lamprecht
3 siblings, 0 replies; 5+ messages in thread
From: Thomas Lamprecht @ 2021-01-12 12:10 UTC (permalink / raw)
To: Proxmox VE development discussion, Gilles Pietri
On 07.01.21 18:02, Gilles Pietri wrote:
> Add the 'none' audio backend as an option for qemu-server: it behaves
> the same as the spice one (id=,driver=), and simply discards audio.
> Add the option in the Web UI for audio configuration.
applied series, much thanks for your contribution!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-01-12 12:11 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-07 17:02 [pve-devel] [PATCH-SERIES] add none audio backend Gilles Pietri
2021-01-07 17:02 ` [pve-devel] [PATCH qemu-server] audio: add the " Gilles Pietri
2021-01-07 17:02 ` [pve-devel] [PATCH pve-manager] ui: qemu: add the none audio driver as an option Gilles Pietri
2021-01-08 12:29 ` [pve-devel] [PATCH-SERIES] add none audio backend Aaron Lauterer
2021-01-12 12:10 ` [pve-devel] applied-series: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox