From: Aaron Lauterer <a.lauterer@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Gilles Pietri <contact+dev@gilouweb.com>
Subject: Re: [pve-devel] [PATCH-SERIES] add none audio backend
Date: Fri, 8 Jan 2021 13:29:46 +0100 [thread overview]
Message-ID: <6638db09-3492-bb37-29b3-64dd606da99b@proxmox.com> (raw)
In-Reply-To: <20210107170244.168204-1-contact+dev@gilouweb.com>
The series looks good to me.
One thing we need to do is to adapt the documentation because right now it specifically mentions that the audio device only works in combination with Spice.
Reviewed-By: Aaron Lauterer <a.lauterer@proxmox.com>
Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>
On 1/7/21 6:02 PM, Gilles Pietri wrote:
> Add the 'none' audio backend as an option for qemu-server: it behaves
> the same as the spice one (id=,driver=), and simply discards audio.
> Add the option in the Web UI for audio configuration.
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
next prev parent reply other threads:[~2021-01-08 12:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 17:02 Gilles Pietri
2021-01-07 17:02 ` [pve-devel] [PATCH qemu-server] audio: add the " Gilles Pietri
2021-01-07 17:02 ` [pve-devel] [PATCH pve-manager] ui: qemu: add the none audio driver as an option Gilles Pietri
2021-01-08 12:29 ` Aaron Lauterer [this message]
2021-01-12 12:10 ` [pve-devel] applied-series: [PATCH-SERIES] add none audio backend Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6638db09-3492-bb37-29b3-64dd606da99b@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=contact+dev@gilouweb.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox