[pve-devel] [PATCH manager/docs 0/3] EC follow ups

[pve-devel] [PATCH manager/docs 0/3] EC follow ups

[Aaron Lauterer]

Some small follow ups. Mainly adapting the docs and API descriptions to
avoid misunderstandings.

Also removign the 'crush_rule' parameter for the EC pool upon creation
as it gets its own crush rule anyway and we cannot change it.

manager: Aaron Lauterer (2):
  ceph pools create: remove crush_rule for ec pool data
  ceph pools create: enhance erasure-code description

 PVE/API2/Ceph/Pools.pm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

pve-docs: Aaron Lauterer (1):
  pveceph: ec pool: add note about parameter usage on creation

 pveceph.adoc | 6 ++++++
 1 file changed, 6 insertions(+)

-- 
2.30.2

[pve-devel] [PATCH manager 1/3] ceph pools create: remove crush_rule for ec pool data

[Aaron Lauterer]

The crush rule is an optional paramter which can be used for the
metadata pool, but the erasure coded data pool will always get its own
crush rule. Therefore this parameter can not be adapted.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
 PVE/API2/Ceph/Pools.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/PVE/API2/Ceph/Pools.pm b/PVE/API2/Ceph/Pools.pm
index 70427277..9c3b8884 100644
--- a/PVE/API2/Ceph/Pools.pm
+++ b/PVE/API2/Ceph/Pools.pm
@@ -474,6 +474,7 @@ __PACKAGE__->register_method ({
 		$ec_data_param->{erasure_code_profile} = $ec->{profile};
 		delete $ec_data_param->{size};
 		delete $ec_data_param->{min_size};
+		delete $ec_data_param->{crush_rule};
 
 		# metadata pool should be ok with 32 PGs
 		$param->{pg_num} = 32;
-- 
2.30.2

[pve-devel] [PATCH manager 2/3] ceph pools create: enhance erasure-code description

[Aaron Lauterer]

Mention which optional parameters will be used for the replicated
metadata pool but won't have an effect on the erasure coded data pool.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
 PVE/API2/Ceph/Pools.pm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/PVE/API2/Ceph/Pools.pm b/PVE/API2/Ceph/Pools.pm
index 9c3b8884..b0517a52 100644
--- a/PVE/API2/Ceph/Pools.pm
+++ b/PVE/API2/Ceph/Pools.pm
@@ -404,7 +404,9 @@ __PACKAGE__->register_method ({
 	    },
 	    'erasure-coding' => {
 		description => "Create an erasure coded pool for RBD with an"
-		    ." accompaning replicated pool for metadata storage.",
+		    ." accompaning replicated pool for metadata storage."
+		    ." The optional 'size', 'min_size' and 'crush_rule'"
+		    ." parameters will be applied to the metadata pool.",
 		type => 'string',
 		format => $ec_format,
 		optional => 1,
-- 
2.30.2

[pve-devel] [PATCH docs 3/3] pveceph: ec pool: add note about parameter usage on creation

[Aaron Lauterer]

Some optional parameters will only be used for the replicated metadata
pool.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
 pveceph.adoc | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/pveceph.adoc b/pveceph.adoc
index dff44e0..abc749b 100644
--- a/pveceph.adoc
+++ b/pveceph.adoc
@@ -595,6 +595,12 @@ providing the '--add_storages 0' parameter.  When configuring the storage
 configuration manually, keep in mind that the 'data-pool' parameter needs to be
 set. Only then will the EC pool be used to store the data objects. For example:
 
+NOTE: The optional parameters '--size', '--min_size' and '--crush_rule' will be
+used for the replicated metadata pool, but not for the erasure coded data pool.
+If you need to change the 'min_size' on the data pool, you can do it later.
+The 'size' and 'crush_rule' parameters cannot be changed on erasure coded
+pools.
+
 [source,bash]
 ----
 pvesm add rbd <storage name> --pool <replicated pool> --data-pool <ec pool>
-- 
2.30.2

[pve-devel] applied: [PATCH docs 3/3] pveceph: ec pool: add note about parameter usage on creation

[Thomas Lamprecht]

Am 5/3/22 um 13:58 schrieb Aaron Lauterer:
> Some optional parameters will only be used for the replicated metadata
> pool.
> 
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
>  pveceph.adoc | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
>

applied, thanks!

FYI: i did a s/'/`/ on the whole EC section, as those are all not file path's I'd guess,
and we normally use the `foo` syntax for parameters and special values in asciidoc.

https://powerman.name/doc/asciidoc#_text

Also added a separate create/add headings below introduction about EC for slightly more
document structure.

[pve-devel] applied-series: [PATCH manager/docs 0/3] EC follow ups

[Thomas Lamprecht]

Am 5/3/22 um 13:58 schrieb Aaron Lauterer:
> Some small follow ups. Mainly adapting the docs and API descriptions to
> avoid misunderstandings.
> 
> Also removign the 'crush_rule' parameter for the EC pool upon creation
> as it gets its own crush rule anyway and we cannot change it.
> 
> manager: Aaron Lauterer (2):
>   ceph pools create: remove crush_rule for ec pool data
>   ceph pools create: enhance erasure-code description
> 
>  PVE/API2/Ceph/Pools.pm | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

applied series, thanks!