From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH novnc] add patches to workaround fullscreen issue in android app
Date: Tue, 21 Dec 2021 09:27:42 +0100 [thread overview]
Message-ID: <655cd024-a651-e85e-d2e1-cbbe71c64603@proxmox.com> (raw)
In-Reply-To: <2982a5c1-3475-c4e7-e830-da69911fcf30@proxmox.com>
On 21/12/2021 08:05, Dominik Csapak wrote:
> On 12/20/21 20:53, Thomas Lamprecht wrote:
>> On 20/12/2021 12:33, Dominik Csapak wrote:
>>> patch 15 hides the fullscreen button,
>>> patch 16 make the error message dismissable
>>>
>>
>> this seems broken?
>>
>> The d/patches/series file gets 16 and 17 added:
>>
>> 0016-hide-fullscreen-button-on-isFullscreen-get-variable.patch
>> 0017-make-error-hideable.patch
>>
>> So above is at least confusing, but actually this diff then only includes the
>> 0017 patch, which then makes it completely wrong?!
>
> what do you mean?
> admittedly i forgot to mention that this only applies on top of the
> v1.3.0 upgrade, but the patches are ...
ah, I got confused by the truncated name in the short log and you wrongly referring
to patch 15 and patch 16 in the commit message..
next prev parent reply other threads:[~2021-12-21 8:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 11:33 Dominik Csapak
2021-12-20 19:53 ` Thomas Lamprecht
2021-12-21 7:05 ` Dominik Csapak
2021-12-21 8:27 ` Thomas Lamprecht [this message]
2021-12-21 10:41 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=655cd024-a651-e85e-d2e1-cbbe71c64603@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox