public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
	"Dominic Jäger" <d.jaeger@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH manager 1/2] Fix #2053: OSD destroy only on specified node
Date: Tue, 20 Apr 2021 18:10:22 +0200	[thread overview]
Message-ID: <6527f71d-183a-f4c3-575a-8ad31bd19e4f@proxmox.com> (raw)
In-Reply-To: <20210111114259.121999-1-d.jaeger@proxmox.com>

On 11.01.21 12:42, Dominic Jäger wrote:
> Allow destroying only OSDs that belong to the node that has been specified in
> the API path.
> 
> So if
>  - OSD 1 belongs to node A and
>  - OSD 2 belongs to node B
> then
>  - pvesh delete nodes/A/ceph/osd/1 is allowed but
>  - pvesh delete nodes/A/ceph/osd/2 is not
> 
> Destroying an OSD via GUI automatically inserts the correct node
> into the API path.
> 
> pveceph automatically insert the local node into the API call, too.
> Consequently, it can now only destroy local OSDs (fix #2053).
>  - pveceph osd destroy 1 is allowed on node A but
>  - pveceph osd destroy 2 is not
> 
> Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
> ---
>  PVE/API2/Ceph/OSD.pm | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
> 
>

applied, thanks!

I reworked the the filtering/parsing the $tree result a bit, maybe you can re-check
if all seem OK to you? The test are def. good and helped here - thanks for them!




      parent reply	other threads:[~2021-04-20 16:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-11 11:42 [pve-devel] " Dominic Jäger
2021-01-11 11:42 ` [pve-devel] [PATCH manager 2/2] Add tests for OSD-belongs-to-node helper Dominic Jäger
2021-04-20 16:10 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6527f71d-183a-f4c3-575a-8ad31bd19e4f@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.jaeger@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal