From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Filip Schauer <f.schauer@proxmox.com>
Subject: [pve-devel] applied: [PATCH v4 common 2/2] tools: Add mount flag constants
Date: Mon, 13 Nov 2023 15:14:47 +0100 [thread overview]
Message-ID: <64abdbdd-3fdd-4506-bd00-6c0b4c38455b@proxmox.com> (raw)
In-Reply-To: <20231113103037.38313-3-f.schauer@proxmox.com>
Am 13/11/2023 um 11:30 schrieb Filip Schauer:
> Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
> ---
> src/PVE/Tools.pm | 31 +++++++++++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
>
>
applied this one already too, thanks!
Albeit I'm not too happy with having those constants in PVE::Tools
in the first place, but there are so many pre-existing ones that
yours don't really make it worse. And just inventing some new
module that takes only yours is not that good either, if we need
to clean this up as a whole, and that's for a separate, future
patch series.
next prev parent reply other threads:[~2023-11-13 14:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 10:30 [pve-devel] [PATCH v4 many] Add container device passthrough Filip Schauer
2023-11-13 10:30 ` [pve-devel] [PATCH v4 common 1/2] tools: Add mknod syscall Filip Schauer
2023-11-13 14:12 ` [pve-devel] applied: " Thomas Lamprecht
2023-11-13 10:30 ` [pve-devel] [PATCH v4 common 2/2] tools: Add mount flag constants Filip Schauer
2023-11-13 14:14 ` Thomas Lamprecht [this message]
2023-11-14 12:57 ` [pve-devel] applied: " Wolfgang Bumiller
2023-11-13 10:30 ` [pve-devel] [PATCH v4 container 1/1] Add device passthrough Filip Schauer
2023-11-15 14:14 ` Thomas Lamprecht
2023-11-16 8:32 ` Wolfgang Bumiller
2023-11-16 11:52 ` Filip Schauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64abdbdd-3fdd-4506-bd00-6c0b4c38455b@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.schauer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox