From: Friedrich Weber <f.weber@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stefan Hanreich <s.hanreich@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-manager v2] postinst: filter rbds in lvm
Date: Tue, 19 Dec 2023 13:10:41 +0100 [thread overview]
Message-ID: <6452ff13-8fba-4c5a-9600-42af4c3ee746@proxmox.com> (raw)
In-Reply-To: <20231215135154.284412-1-s.hanreich@proxmox.com>
Tested-by: Friedrich Weber <f.weber@proxmox.com>
Tried a couple of upgrades from PVE 7 to PVE 8 (including pve-manager
with this patch). When upgrading, dpkg asks (in most cases) whether to
keep local /etc/lvm/lvm.conf or install package maintainer version, so I
tried both answers. Results were as I'd expect. I'm showing the pre- and
post-upgrade contents of the `devices {}` block below.
* default PVE 7 lvm.conf (with zvol filter):
** keeping local version
=> post-upgrade lvm.conf:
# added by pve-manager to avoid scanning ZFS zvols and Ceph rbds
# global_filter=["r|/dev/zd.*|"]
global_filter=["r|/dev/zd.*|","r|/dev/rbd.*|"]
** installing package maintainer version
=> post-upgrade lvm.conf:
# added by pve-manager to avoid scanning ZFS zvols and Ceph rbds
global_filter=["r|/dev/zd.*|","r|/dev/rbd.*|"]
* custom lvm.conf 7 with "# added" marker:
# added by pve-manager to avoid scanning ZFS zvols
global_filter=["r|/dev/zd.*|",
"r|/dev/foo|"]
** keeping local version
=> custom config is kept and untouched
** installing package maintainer version
=> post-upgrade lvm.conf:
# added by pve-manager to avoid scanning ZFS zvols and Ceph rbds
global_filter=["r|/dev/zd.*|","r|/dev/rbd.*|"]
* custom lvm.conf on PVE 7 without "# added" marker:
global_filter=["r|/dev/zd.*|", "r|/dev/foo|"]
** keeping local version:
=> custom config is kept and untouched
** install package maintainer version
=> post-upgrade lvm.conf:
# added by pve-manager to avoid scanning ZFS zvols and Ceph rbds
global_filter=["r|/dev/zd.*|","r|/dev/rbd.*|"]
* upstream unmodified lvm.conf without any global_filter
LVM does not ask which version to take
=> post-upgrade lvm.conf:
# added by pve-manager to avoid scanning ZFS zvols and Ceph rbds
global_filter=["r|/dev/zd.*|","r|/dev/rbd.*|"]
prev parent reply other threads:[~2023-12-19 12:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 13:51 Stefan Hanreich
2023-12-15 14:10 ` Stefan Hanreich
2023-12-19 11:54 ` Fabian Grünbichler
2023-12-19 13:13 ` Stefan Hanreich
2023-12-19 12:10 ` Friedrich Weber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6452ff13-8fba-4c5a-9600-42af4c3ee746@proxmox.com \
--to=f.weber@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.hanreich@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox