Re: [pve-devel] partially-applied: [PATCH manager v2 00/12] multi tab disk panel & multi disk wizard

From: Aaron Lauterer <a.lauterer@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Thomas Lamprecht <t.lamprecht@proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pve-devel] partially-applied: [PATCH manager v2 00/12] multi tab disk panel & multi disk wizard
Date: Tue, 19 Oct 2021 15:04:02 +0200	[thread overview]
Message-ID: <641ef788-8ede-d6dc-7697-2fa41ee00a5e@proxmox.com> (raw)
In-Reply-To: <724abcda-3bda-dbe6-ac18-7b81339fe284@proxmox.com>

On 10/4/21 09:36, Thomas Lamprecht wrote:
> On 22.09.21 11:27, Dominik Csapak wrote:
>> this series is intended to replace dominics and my previous attempts
>> at this [0][1][2]
>>
>> splits the bandwidth options into their on tab on the disk panel and
>> introduces a 'MultiHDEdit' panel which creates/deletes the
>> HDEdit panels on demand.
>>
>> The UX is modeled after Dominics first attempt, but a very different
>> approach code-wise. instead of having a seperate 'data' panel that
>> contains the vm config, let the multi disk panel handle that
>> and pass it through to the panels below. this way the HDEdit does
>> not need a big code-change to get/set the config.
>>
>> changes from v1:
>> * fixed a bug which prevented the wizard from finishing
>> * made the wizard a little wider so that the form field labes are
>>    readable
>> * added logic to use the ostype to determine the first disk if one
>>    deleted all before
>>
>> patch 10/12 and 12/12 are new, other changes are in 11/12
>>
>> 0: https://lists.proxmox.com/pipermail/pve-devel/2021-June/048690.html
>> 1: https://lists.proxmox.com/pipermail/pve-devel/2021-July/049295.html
>> 2: https://lists.proxmox.com/pipermail/pve-devel/2021-September/050013.html
>>
>> Dominik Csapak (12):
>>    ui: qemu/HDEdit: move Bandwidth options to a different tab
>>    ui: form/ControllerSelector: set correct max value for the device-id
>>    ui: refactor sortByPreviousUsage and nextFreeDisk
>>    ui: form/ControllerSelector: add updateVMConfig and getConfId
>>    ui: qemu/HDEdit: use me instead of this
>>    ui: qemu/HDEdit: fire an event when the disk id changes
>>    ui: qemu/OSTypeEdit: drop throwing an error on multiple widgets
>>    ui: Utils: add capture group for the id in bus_match
>>    ui: form/ControllerSelector: add option for selecting free on inital
>>      config
>>    ui: qemu/OSTypeEdit: set ostype in viewmodel
> 
> applied above, delayed below; mostly because I'd like to have some feedback from
> others here and I'd also like to have the same for CT, to avoid a feature drift in
> the wizards.

I took the last two patches for a quick spin, and I have to say that I do like the functionality. Yes it does change the way one interacts with the wizard quite a bit, but it really makes it so much easier to create VMs with no disks at all (useful when preparing for qm importdisk) or more than one disk.

> 
> thanks!
> 
>>    ui: add qemu/MultiHDEdit and use it in the wizard
>>    ui: window/Wizard: make it a little wider
>>
>>   www/manager6/Makefile                   |   1 +
>>   www/manager6/Utils.js                   |  48 +++-
>>   www/manager6/form/ControllerSelector.js |  65 +++---
>>   www/manager6/qemu/CreateWizard.js       |   4 +-
>>   www/manager6/qemu/HDEdit.js             | 143 ++++++++----
>>   www/manager6/qemu/MultiHDEdit.js        | 294 ++++++++++++++++++++++++
>>   www/manager6/qemu/OSTypeEdit.js         |   3 +-
>>   www/manager6/window/Wizard.js           |   7 +-
>>   8 files changed, 482 insertions(+), 83 deletions(-)
>>   create mode 100644 www/manager6/qemu/MultiHDEdit.js
>>
> 
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
> 