From: Filip Schauer <f.schauer@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] applied: [PATCH v5 manager 0/2] add edit window for device passthrough
Date: Wed, 17 Apr 2024 12:03:48 +0200 [thread overview]
Message-ID: <6412a657-7c79-4c87-ae74-5b6ae725a542@proxmox.com> (raw)
In-Reply-To: <7d97b66f-4b3d-4276-908b-1d3ad3d91034@proxmox.com>
That is already fixed by this commit to pve-container:
https://git.proxmox.com/?p=pve-container.git;a=commitdiff;h=556ddd393165d51653fe32c1f8fe8628d1802219
On 17/04/2024 11:54, Thomas Lamprecht wrote:
> Also noticed something not related to the UI side: if I enter some bogus path,
> like `/dev/enoent`, I correctly get an error that this does not exist, but the
> config entry is added nonetheless!
> Which then also means that if I keep the dialogue open and correct the dev
> path, I won't be able to submit as the config digest changed, I need to close
> and re-open the add/edit dialogue again. This is not only bad UX, but seems
> completely broken?
>
> Also, if I got some bogus devX entries already, the error I get when saving
> a new one is often from them, not from the one I add, but the change also
> goes through here...
>
> Please check that out.
prev parent reply other threads:[~2024-04-17 10:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 8:44 [pve-devel] " Filip Schauer
2024-04-17 8:44 ` [pve-devel] [PATCH v5 manager 1/2] utils: clarify naming of LXC mount point utils Filip Schauer
2024-04-17 8:44 ` [pve-devel] [PATCH v5 manager 2/2] ui: lxc: add edit window for device passthrough Filip Schauer
2024-04-17 9:54 ` [pve-devel] applied: [PATCH v5 manager 0/2] " Thomas Lamprecht
2024-04-17 10:03 ` Filip Schauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6412a657-7c79-4c87-ae74-5b6ae725a542@proxmox.com \
--to=f.schauer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox